Skip to content

Commit 0c41a82

Browse files
authored
Merge pull request #4667 from aramissennyeydd/sennyeya/fix-cobuild-symbols
[console-timeline] update: show only cobuild build steps in the build timeline
2 parents 7a6b721 + 030c7a7 commit 0c41a82

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"changes": [
3+
{
4+
"packageName": "@microsoft/rush",
5+
"comment": "Timeline view will now only show terminal build statuses as cobuilt, all other statuses will reflect their original icons.",
6+
"type": "none"
7+
}
8+
],
9+
"packageName": "@microsoft/rush"
10+
}

libraries/rush-lib/src/logic/operations/ConsoleTimelinePlugin.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,13 @@ const TIMELINE_CHART_SYMBOLS: Record<OperationStatus, string> = {
8989
[OperationStatus.NoOp]: '%'
9090
};
9191

92+
const COBUILD_REPORTABLE_STATUSES: Set<OperationStatus> = new Set([
93+
OperationStatus.Success,
94+
OperationStatus.SuccessWithWarning,
95+
OperationStatus.Failure,
96+
OperationStatus.Blocked
97+
]);
98+
9299
/**
93100
* Timeline - colorizer for each operation status
94101
*/
@@ -232,7 +239,7 @@ export function _printTimeline({ terminal, result, cobuildConfiguration }: IPrin
232239

233240
function getChartSymbol(record: ITimelineRecord): string {
234241
const { isExecuteByOtherCobuildRunner, status } = record;
235-
if (isExecuteByOtherCobuildRunner) {
242+
if (isExecuteByOtherCobuildRunner && COBUILD_REPORTABLE_STATUSES.has(status)) {
236243
hasCobuildSymbol = true;
237244
return 'C';
238245
}

0 commit comments

Comments
 (0)