ci: nightly builds against react-native-macos/-windows canaries (#328)

Author: tido64

.github/workflows/build.yml

@@ -304,7 +304,7 @@ jobs:
   macos:
     name: "macOS"
     runs-on: macos-latest
-    if: ${{ github.event_name != 'schedule' && !contains(github.event.head_commit.message, '[skip ci]') }}
+    if: ${{ !contains(github.event.head_commit.message, '[skip ci]') }}
     steps:
       - name: Set up Node.js
         uses: actions/[email protected]
@@ -317,6 +317,11 @@ jobs:
         with:
           path: example/.yarn-offline-mirror
           key: ${{ hashFiles('example/yarn.lock') }}
+      - name: Set up react-native@canary
+        if: ${{ github.event_name == 'schedule' }}
+        run: |
+          yarn set-react-version canary-macos
+        shell: bash
       - name: Install
         run: |
           yarn ci
@@ -386,10 +391,10 @@ jobs:
   windows:
     name: "Windows"
     runs-on: windows-latest
-    if: ${{ github.event_name != 'schedule' && !contains(github.event.head_commit.message, '[skip ci]') }}
+    if: ${{ !contains(github.event.head_commit.message, '[skip ci]') }}
     strategy:
       matrix:
-        platform: [ARM, x64]
+        platform: [ARM64, x64]
         configuration: [Debug, Release]
     steps:
       - name: Set up MSBuild
@@ -407,6 +412,11 @@ jobs:
         with:
           path: example/.yarn-offline-mirror
           key: ${{ hashFiles('example/yarn.lock') }}
+      - name: Set up react-native@canary
+        if: ${{ github.event_name == 'schedule' }}
+        run: |
+          yarn set-react-version canary-windows
+        shell: bash
       - name: Install
         run: |
           yarn ci
@@ -425,9 +435,10 @@ jobs:
           MSBuild Example.sln -t:Rebuild -p:Configuration=${{ matrix.configuration }} -p:Platform=${{ matrix.platform }}
         working-directory: example/windows
       - name: Test
+        if: ${{ matrix.platform == 'x64' }}
         run: |
           MSBuild ReactTestAppTests.vcxproj -t:Build -p:Configuration=${{ matrix.configuration }} -p:Platform=${{ matrix.platform }}
-          if ("${{ matrix.platform }}" -eq "x64") { VSTest.Console.exe ${{ matrix.platform }}\${{ matrix.configuration }}\ReactTestAppTests.dll }
+          VSTest.Console.exe ${{ matrix.platform }}\${{ matrix.configuration }}\ReactTestAppTests.dll
         working-directory: example/windows/ReactTestAppTests
   windows-template:
     name: "Windows [template]"

example/windows/ReactTestAppTests/ReactTestAppTests.vcxproj

@@ -38,13 +38,13 @@ IMP RTASwizzleSelector(Class class, SEL originalSelector, SEL swizzledSelector)
 
 // `RCTReloadCommand.h` is excluded from `react-native-macos`
 // See https://github.com/microsoft/react-native-macos/blob/v0.61.39/React-Core.podspec#L66
-#if REACT_NATIVE_VERSION >= 6200
+#if REACT_NATIVE_VERSION == 0 || REACT_NATIVE_VERSION >= 6200
 #import <React/RCTReloadCommand.h>
 #endif
 
 void RTATriggerReloadCommand(RCTBridge *bridge, NSString *reason)
 {
-#if REACT_NATIVE_VERSION < 6200
+#if REACT_NATIVE_VERSION > 0 && REACT_NATIVE_VERSION < 6200
     [bridge reload];
 #else
     RCTTriggerReloadCommandListeners(reason);

ios/ReactTestApp/React+Compatibility.m

@@ -38,6 +38,18 @@ const profiles = {
     "react-native-macos": undefined,
     "react-native-windows": "^0.64.11",
   },
+  "canary-macos": {
+    react: "16.13.1",
+    "react-native": "^0.63.4",
+    "react-native-macos": "canary",
+    "react-native-windows": undefined,
+  },
+  "canary-windows": {
+    react: "17.0.2",
+    "react-native": "^0.64.2",
+    "react-native-macos": undefined,
+    "react-native-windows": "canary",
+  },
   master: {
     react: "17.0.2",
     "react-native": "facebook/react-native#master",

scripts/set-react-version.js

@@ -44,5 +44,7 @@ describe("getVersionNumber", () => {
     expect(getVersionNumber("1.1.0.1")).toBe(1010001);
     expect(getVersionNumber("1.1.1.0")).toBe(1010100);
     expect(getVersionNumber("1.1.1.1")).toBe(1010101);
+
+    expect(getVersionNumber("1.0.0-rc.1")).toBe(10000);
   });
 });

test/windows-test-app/getVersionNumber.test.js

@@ -14,7 +14,7 @@
         <AppContainerApplication>true</AppContainerApplication>
         <ApplicationType>Windows Store</ApplicationType>
         <ApplicationTypeRevision>10.0</ApplicationTypeRevision>
-        <WindowsTargetPlatformVersion Condition=" '$(WindowsTargetPlatformVersion)' == '' ">10.0.18362.0</WindowsTargetPlatformVersion>
+        <WindowsTargetPlatformVersion Condition=" '$(WindowsTargetPlatformVersion)' == '' ">10.0.19041.0</WindowsTargetPlatformVersion>
         <WindowsTargetPlatformMinVersion>10.0.17763.0</WindowsTargetPlatformMinVersion>
         <PackageCertificateKeyFile>ReactTestApp_TemporaryKey.pfx</PackageCertificateKeyFile>
         <PackageCertificateThumbprint>4AC7A41A12F06BCFEDBADCE05ECFFDF546109B66</PackageCertificateThumbprint>
@@ -126,21 +126,20 @@
             <AdditionalOptions>%(AdditionalOptions) /bigobj</AdditionalOptions>
             <!--Temporarily disable cppwinrt heap enforcement to work around xaml compiler generated std::shared_ptr use -->
             <AdditionalOptions Condition="'$(CppWinRTHeapEnforcement)'==''">/DWINRT_NO_MAKE_DETECTION %(AdditionalOptions)</AdditionalOptions>
-            <DisableSpecificWarnings>
-            </DisableSpecificWarnings>
+            <DisableSpecificWarnings></DisableSpecificWarnings>
             <PreprocessorDefinitions>WIN32_LEAN_AND_MEAN;WINRT_LEAN_AND_MEAN;REACT_NATIVE_VERSION=10000000;%(PreprocessorDefinitions)</PreprocessorDefinitions>
         </ClCompile>
     </ItemDefinitionGroup>
     <ItemDefinitionGroup Condition="'$(Configuration)'=='Debug'">
         <ClCompile>
             <PreprocessorDefinitions>_DEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
-            <TreatWarningAsError>true</TreatWarningAsError>
+            <TreatWarningAsError>false</TreatWarningAsError>
         </ClCompile>
     </ItemDefinitionGroup>
     <ItemDefinitionGroup Condition="'$(Configuration)'=='Release'">
         <ClCompile>
             <PreprocessorDefinitions>NDEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
-            <TreatWarningAsError>true</TreatWarningAsError>
+            <TreatWarningAsError>false</TreatWarningAsError>
         </ClCompile>
     </ItemDefinitionGroup>
     <ItemGroup>

windows/ReactTestApp/ReactTestApp.vcxproj

@@ -261,7 +261,7 @@ function getPackageVersion(packagePath) {
  * @returns {number}
  */
 function getVersionNumber(version) {
-  const components = version.split(".");
+  const components = version.split("-")[0].split(".");
   const lastIndex = components.length - 1;
   return components.reduce(
     /** @type {(sum: number, value: string, index: number) => number} */