Merge pull request #10 from microsoft/benjaming/address-codeql

Address CodeQL

Author: bgn64

Diff for: src/ProfileExplorerCore/Utilities/CompressionUtils.cs

@@ -39,21 +39,6 @@ public static string DecompressString(byte[] data) {
     return Encoding.UTF8.GetString(Decompress(data));
   }
 
-  public static byte[] CreateMD5(byte[] data) {
-    using var md5 = MD5.Create();
-    return md5.ComputeHash(data);
-  }
-
-  public static string CreateMD5String(byte[] data) {
-    byte[] hash = CreateMD5(data);
-    return BitConverter.ToString(hash).Replace("-", string.Empty, StringComparison.Ordinal).
-      ToLowerInvariant();
-  }
-
-  public static string CreateMD5String(string text) {
-    return CreateMD5String(Encoding.UTF8.GetBytes(text));
-  }
-
   public static byte[] CreateSHA256(byte[] data) {
     using var sha = SHA256.Create();
     return sha.ComputeHash(data);

Diff for: src/ProfileExplorerUI/Binary/PDBDebugInfoProvider.cs

@@ -638,6 +638,10 @@ private bool SourceFileChecksumMatchesPDB(IDiaSourceFile sourceFile, string file
     }
 
     var hashAlgo = GetSourceFileChecksumHashAlgorithm(sourceFile);
+    if (hashAlgo == null) {
+      return false;
+    }
+
     byte[] pdbChecksum = GetSourceFileChecksum(sourceFile);
     byte[] fileChecksum = ComputeSourceFileChecksum(filePath, hashAlgo);
     return pdbChecksum != null && fileChecksum != null &&
@@ -695,10 +699,8 @@ private bool SourceFileChecksumMatchesPDB(IDiaSourceFile sourceFile, string file
 
   private HashAlgorithm GetSourceFileChecksumHashAlgorithm(IDiaSourceFile sourceFile) {
     return sourceFile.checksumType switch {
-      1 => MD5.Create(),
-      2 => SHA1.Create(),
       3 => SHA256.Create(),
-      _ => MD5.Create()
+      _ => null
     };
   }