Skip to content

Commit dd87b30

Browse files
authored
fix: npe in page.pause() (#1828)
1 parent f83c03a commit dd87b30

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

playwright/src/main/java/com/microsoft/playwright/impl/PageImpl.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1008,15 +1008,16 @@ public PageImpl opener() {
10081008

10091009
@Override
10101010
public void pause() {
1011-
Double defaultNavigationTimeout = browserContext.timeoutSettings.defaultNavigationTimeout();
1012-
Double defaultTimeout = browserContext.timeoutSettings.defaultTimeout();
1013-
browserContext.setDefaultNavigationTimeout(0.0);
1014-
browserContext.setDefaultTimeout(0.0);
1011+
TimeoutSettings settings = browserContext.timeoutSettings;
1012+
Double defaultNavigationTimeout = settings.defaultNavigationTimeout();
1013+
Double defaultTimeout = settings.defaultTimeout();
1014+
settings.setDefaultNavigationTimeout(0.0);
1015+
settings.setDefaultTimeout(0.0);
10151016
try {
10161017
runUntil(() -> {}, new WaitableRace<>(asList(context().pause(), (Waitable<JsonElement>) waitableClosedOrCrashed)));
10171018
} finally {
1018-
browserContext.setDefaultNavigationTimeout(defaultNavigationTimeout);
1019-
browserContext.setDefaultTimeout(defaultTimeout);
1019+
settings.setDefaultNavigationTimeout(defaultNavigationTimeout);
1020+
settings.setDefaultTimeout(defaultTimeout);
10201021
}
10211022
}
10221023

playwright/src/test/java/com/microsoft/playwright/TestPageBasic.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -356,4 +356,10 @@ void shouldProhibitNullListeners() {
356356

357357
assertTrue(e.getMessage().contains("Can't add a null listener"));
358358
}
359+
360+
@Test
361+
void pagePauseShouldNotThrow() {
362+
page.pause();
363+
}
364+
359365
}

0 commit comments

Comments
 (0)