Skip to content

Commit 739202f

Browse files
authored
test: do not send Content-Length header for HEAD requests (#1771)
1 parent 8593941 commit 739202f

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

playwright/src/test/java/com/microsoft/playwright/Server.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ public void handle(HttpExchange exchange) throws IOException {
218218
}
219219
long contentLength = body.size();
220220
// -1 means no body, 0 means chunked encoding.
221-
exchange.sendResponseHeaders(200, contentLength == 0 ? -1 : contentLength);
221+
exchange.sendResponseHeaders(200, (contentLength == 0 || exchange.getRequestMethod().equals("HEAD")) ? -1 : contentLength);
222222
if (contentLength > 0) {
223223
exchange.getResponseBody().write(body.toByteArray());
224224
}

playwright/src/test/java/com/microsoft/playwright/TestBrowserContextCredentials.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ static boolean isChromiumHeadedLike() {
3333
@Test
3434
@DisabledIf(value="isChromiumHeadedLike", disabledReason="fail")
3535
void shouldFailWithoutCredentials() {
36-
System.out.println("channel2 " + getBrowserChannelFromEnv());
3736
server.setAuth("/empty.html", "user", "pass");
3837
Response response = page.navigate(server.EMPTY_PAGE);
3938
assertEquals(401, response.status());

playwright/src/test/java/com/microsoft/playwright/TestGlobalFetch.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ void shouldReturnBodyForFailingRequests() {
337337
for (String method : new String[] {"head", "put", "trace"}) {
338338
server.setRoute("/empty.html", exchange -> {
339339
exchange.getResponseHeaders().set("Content-type", "text/plain");
340-
exchange.sendResponseHeaders(404, 10);
340+
exchange.sendResponseHeaders(404, exchange.getRequestMethod().equals("HEAD") ? -1 : 10);
341341
try (Writer writer = new OutputStreamWriter(exchange.getResponseBody())) {
342342
writer.write("Not found.");
343343
}

0 commit comments

Comments
 (0)