[js/node] gpuMemLimit only useful to be bigint

nomagick · nomagick · commit f8cf9a3e963c · 2024-12-31T17:02:00.000+08:00
diff --git a/js/common/lib/inference-session.ts b/js/common/lib/inference-session.ts
@@ -223,7 +223,7 @@ export declare namespace InferenceSession {
   export interface CudaExecutionProviderOption extends ExecutionProviderOption {
     readonly name: 'cuda';
     deviceId?: number;
-    gpuMemLimit?: number;
+    gpuMemLimit?: bigint;
 
     /**
      * Arena extend strategy. See
diff --git a/js/node/src/session_options_helper.cc b/js/node/src/session_options_helper.cc
@@ -70,7 +70,7 @@ void ParseExecutionProviders(const Napi::Array epList, Ort::SessionOptions& sess
       }
       if (obj.Has("gpuMemLimit")) {
         gpuMemLimit = static_cast<size_t>(
-            obj.Get("gpuMemLimit").As<Napi::Number>().Uint32Value());
+            obj.Get("gpuMemLimit").As<Napi::BigInt>().Uint64Value());
       }
 #endif
 #ifdef USE_COREML

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ void ParseExecutionProviders(const Napi::Array epList, Ort::SessionOptions& sess`
`70`	`70`	`}`
`71`	`71`	`if (obj.Has("gpuMemLimit")) {`
`72`	`72`	`gpuMemLimit = static_cast<size_t>(`
`73`		`- obj.Get("gpuMemLimit").As<Napi::Number>().Uint32Value());`
	`73`	`+ obj.Get("gpuMemLimit").As<Napi::BigInt>().Uint64Value());`
`74`	`74`	`}`
`75`	`75`	`#endif`
`76`	`76`	`#ifdef USE_COREML`