Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Commit 06f45f3

Browse files
authored
Update Task Heartbeat to include Job_id (#594)
1 parent 6a049db commit 06f45f3

File tree

4 files changed

+10
-3
lines changed

4 files changed

+10
-3
lines changed

src/agent/onefuzz-agent/src/tasks/config.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ impl CommonConfig {
4747
pub async fn init_heartbeat(&self) -> Result<Option<TaskHeartbeatClient>> {
4848
match &self.heartbeat_queue {
4949
Some(url) => {
50-
let hb = init_task_heartbeat(url.clone(), self.task_id).await?;
50+
let hb = init_task_heartbeat(url.clone(), self.task_id, self.job_id).await?;
5151
Ok(Some(hb))
5252
}
5353
None => Ok(None),

src/agent/onefuzz-agent/src/tasks/heartbeat.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,24 @@ struct Heartbeat {
2626
#[derive(Clone)]
2727
pub struct TaskContext {
2828
task_id: Uuid,
29+
job_id: Uuid,
2930
machine_id: Uuid,
3031
machine_name: String,
3132
}
3233

3334
pub type TaskHeartbeatClient = HeartbeatClient<TaskContext, HeartbeatData>;
3435

35-
pub async fn init_task_heartbeat(queue_url: Url, task_id: Uuid) -> Result<TaskHeartbeatClient> {
36+
pub async fn init_task_heartbeat(
37+
queue_url: Url,
38+
task_id: Uuid,
39+
job_id: Uuid,
40+
) -> Result<TaskHeartbeatClient> {
3641
let machine_id = get_machine_id().await?;
3742
let machine_name = get_machine_name().await?;
3843
let hb = HeartbeatClient::init_heartbeat(
3944
TaskContext {
4045
task_id,
46+
job_id,
4147
machine_id,
4248
machine_name,
4349
},

src/api-service/__app__/queue_task_heartbeat/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def main(msg: func.QueueMessage, dashboard: func.Out[str]) -> None:
3030
task.heartbeat = datetime.utcnow()
3131
task.save()
3232
except ValidationError:
33-
logging.error("invalid task heartbat: %s", raw)
33+
logging.error("invalid task heartbeat: %s", raw)
3434

3535
events = get_events()
3636
if events:

src/pytypes/onefuzztypes/models.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -516,6 +516,7 @@ class Job(BaseModel):
516516

517517
class TaskHeartbeatEntry(BaseModel):
518518
task_id: UUID
519+
job_id: Optional[UUID]
519520
machine_id: UUID
520521
data: List[Dict[str, HeartbeatType]]
521522

0 commit comments

Comments
 (0)