Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing properties on generated Python code models if additionalProperties: false on OpenAPI component schema #5037

Closed
geometrikal opened this issue Jul 30, 2024 · 2 comments · Fixed by #5041
Assignees
Labels
Python type:bug A broken experience WIP
Milestone

Comments

@geometrikal
Copy link

What are you generating using Kiota, clients or plugins?

API Client/SDK

In what context or format are you using Kiota?

Nuget tool

Client library/SDK language

Python

Describe the bug

Generated python models results have no properties, making it difficult to discover properties using IDE autocomplete. This happens when additionalProperties: false is present on the OpenAPI component schema.

Expected behavior

Properties are generated

How to reproduce

Try this example with and without additionalProperties

components:
  schemas:
    Image:
      type: object
      properties:
        frame:
          type: integer
          format: int32
        path:
          type: string
          nullable: true
      additionalProperties: false

Open API description file

No response

Kiota Version

1.16.0+f7ce8b88eefa1c00cb6f87dd48335baac96d2cc9

Latest Kiota version known to work for scenario above?(Not required)

No response

Known Workarounds

No response

Configuration

No response

Debug output

Click to expand log ```
</details>


### Other information

_No response_
@geometrikal geometrikal added status:waiting-for-triage An issue that is yet to be reviewed or assigned type:bug A broken experience labels Jul 30, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Jul 30, 2024
@msgraph-bot msgraph-bot bot added the Python label Jul 30, 2024
@baywet baywet self-assigned this Jul 30, 2024
@baywet baywet removed the status:waiting-for-triage An issue that is yet to be reviewed or assigned label Jul 30, 2024
@baywet baywet moved this from Needs Triage 🔍 to Todo 📃 in Kiota Jul 30, 2024
@baywet baywet moved this from Todo 📃 to In Progress 🚧 in Kiota Jul 30, 2024
@baywet baywet added this to the Kiota v1.17 milestone Jul 30, 2024
@baywet
Copy link
Member

baywet commented Jul 30, 2024

Hi @geometrikal
Thanks for using kiota and for reporting this issue.
I put together #5041 to address it.

@andrueastman
Copy link
Member

This should also be related to #4643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python type:bug A broken experience WIP
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants