Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

[RFC]: Colors - choosing text color for box components (where color props sets background color) #629

Closed
bmdalex opened this issue Dec 18, 2018 · 3 comments
Assignees
Labels
💥 blocked ⚙️ enhancement New feature or request question Further information is requested, concerns that require additional thought are raised RFC vsts Paired with ticket in vsts

Comments

@bmdalex
Copy link
Collaborator

bmdalex commented Dec 18, 2018

[RFC]: Colors - choosing text color for box components (where color props sets background color)

Problem description

We need to automatically change text color for box components (components where color prop goes to background color)

What tool to use for deciding text color for different background shades?

Proposed solution

Use color package and Color(bgColor).isDark call to determine if the text is light or dark, but it looks like this is not a preferred package to import? see:
#597 (comment)

@bmdalex
Copy link
Collaborator Author

bmdalex commented Dec 18, 2018

Q: How do we choose the shades of light and dark text colors?

A: We need to:

  • wait for designers to give us the right redlines for what text colors to use;
  • we need to create more proposals and iterate on them, @levithomason would be great if you could summarize your thoughts on these proposals

@bmdalex bmdalex changed the title [RFC]: Colors - choosing the text color for box components (where color props sets background color) [RFC]: Colors - choosing text color for box components (where color props sets background color) Dec 18, 2018
@bmdalex bmdalex self-assigned this Dec 18, 2018
@bmdalex bmdalex added RFC 💥 blocked ⚙️ enhancement New feature or request question Further information is requested, concerns that require additional thought are raised labels Dec 18, 2018
@pkumarie2011 pkumarie2011 added the vsts Paired with ticket in vsts label Dec 18, 2018
This was referenced Dec 18, 2018
@layershifter
Copy link
Member

We need to automatically change text color for box components

I think that we don't need to do something automatically, we should define mapping explicitly. As I see, described issue should be covered by #636.

@bmdalex
Copy link
Collaborator Author

bmdalex commented Dec 20, 2018

closing as this is covered by #636 now

@bmdalex bmdalex closed this as completed Dec 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💥 blocked ⚙️ enhancement New feature or request question Further information is requested, concerns that require additional thought are raised RFC vsts Paired with ticket in vsts
Projects
None yet
Development

No branches or pull requests

3 participants