Summary
The 8 reusable lint workflows introduced in PR #240 (#235) use three inconsistent patterns for consuming the soft-fail input parameter. This creates unnecessary maintenance burden and makes behavior harder to reason about.
Current State
| Pattern |
Workflows |
Example |
Direct injection in if: |
shell-lint, terraform-lint, code-quality-lint, bicep-lint |
if: failure() && inputs.soft-fail == true |
| Environment variable |
docs-lint, yaml-lint |
env: SOFT_FAIL: ${{ inputs.soft-fail }} then if: env.SOFT_FAIL != 'true' |
| Negated condition |
powershell-lint, security-scan |
if: inputs.soft-fail != true |
Acceptance Criteria
References
Summary
The 8 reusable lint workflows introduced in PR #240 (#235) use three inconsistent patterns for consuming the
soft-failinput parameter. This creates unnecessary maintenance burden and makes behavior harder to reason about.Current State
if:if: failure() && inputs.soft-fail == trueenv: SOFT_FAIL: ${{ inputs.soft-fail }}thenif: env.SOFT_FAIL != 'true'if: inputs.soft-fail != trueAcceptance Criteria
soft-failinput consumptionpr-validation.ymlandmain.ymlcontinue to function correctlyReferences