Address logger review findings

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: d3b014e3-808e-455f-b932-01d0a7aa5c93

Author: andystaples

durabletask/client.py

@@ -423,6 +423,7 @@ def __init__(self, *,
                  data_converter: DataConverter | None = None,
                  emit_trace_spans: bool = True):
 
+        self._logger = shared.get_logger("client", log_handler, log_formatter, logger)
         self._owns_channel = channel is None
         self._data_converter = data_converter if data_converter is not None else JsonDataConverter()
         self._host_address = (
@@ -483,7 +484,6 @@ def __init__(self, *,
         # can prepend the interceptor themselves via grpc.intercept_channel.
         self._channel = channel
         self._stub = cast(_SyncTaskHubSidecarServiceStub, stubs.TaskHubSidecarServiceStub(channel))
-        self._logger = shared.get_logger("client", log_handler, log_formatter, logger)
         self.default_version = default_version
         self._payload_store = payload_store
         self._emit_trace_spans = emit_trace_spans
@@ -953,6 +953,7 @@ def __init__(self, *,
                  data_converter: DataConverter | None = None,
                  emit_trace_spans: bool = True):
 
+        self._logger = shared.get_logger("async_client", log_handler, log_formatter, logger)
         self._owns_channel = channel is None
         self._data_converter = data_converter if data_converter is not None else JsonDataConverter()
         self._host_address = (
@@ -1010,7 +1011,6 @@ def __init__(self, *,
             if channel is not None
             else None
         )
-        self._logger = shared.get_logger("async_client", log_handler, log_formatter, logger)
         self.default_version = default_version
         self._payload_store = payload_store
         self._emit_trace_spans = emit_trace_spans

durabletask/internal/shared.py

@@ -81,7 +81,7 @@ def _get_legacy_logging_warning_stacklevel() -> int:
 
     while frame is not None:
         module_name = frame.f_globals.get("__name__", "")
-        if not module_name.startswith("durabletask"):
+        if module_name != "durabletask" and not module_name.startswith("durabletask."):
             break
         stacklevel += 1
         frame = frame.f_back

tests/durabletask/test_logging.py

@@ -7,6 +7,7 @@
 import pytest
 
 from durabletask.client import AsyncTaskHubGrpcClient, TaskHubGrpcClient
+from durabletask.internal.shared import get_logger
 from durabletask.worker import TaskHubGrpcWorker
 
 
@@ -55,3 +56,49 @@ def test_logger_cannot_be_combined_with_legacy_logging_options():
             logger=logging.Logger("test.durabletask"),
             log_handler=logging.NullHandler(),
         )
+
+
+def test_logger_conflict_does_not_create_a_sync_grpc_channel(monkeypatch):
+    def unexpected_channel_creation(*args, **kwargs):
+        raise AssertionError("A gRPC channel should not be created for invalid logging options.")
+
+    monkeypatch.setattr("durabletask.client.shared.get_grpc_channel", unexpected_channel_creation)
+
+    with pytest.raises(ValueError, match="cannot be combined"):
+        TaskHubGrpcClient(
+            logger=logging.Logger("test.durabletask"),
+            log_handler=logging.NullHandler(),
+        )
+
+
+def test_logger_conflict_does_not_create_an_async_grpc_channel(monkeypatch):
+    def unexpected_channel_creation(*args, **kwargs):
+        raise AssertionError("A gRPC channel should not be created for invalid logging options.")
+
+    monkeypatch.setattr("durabletask.client.shared.get_async_grpc_channel", unexpected_channel_creation)
+
+    with pytest.raises(ValueError, match="cannot be combined"):
+        AsyncTaskHubGrpcClient(
+            logger=logging.Logger("test.durabletask"),
+            log_handler=logging.NullHandler(),
+        )
+
+
+def test_legacy_logging_warning_does_not_skip_similarly_named_application_module():
+    namespace = {
+        "__name__": "durabletask_app",
+        "get_logger": get_logger,
+        "logging": logging,
+    }
+    exec(
+        "def create_logger():\n"
+        "    return get_logger('test', log_handler=logging.NullHandler())\n",
+        namespace,
+    )
+
+    with pytest.warns(DeprecationWarning, match="log_handler") as warnings:
+        namespace["create_logger"]()
+
+    warning = next(warning for warning in warnings if "log_handler" in str(warning.message))
+    assert warning.filename == "<string>"
+    assert warning.lineno == 2