fix: make gha workflow dependent on package manager (#70)

Author: mxschmitt

assets/github-actions.yml

@@ -16,7 +16,7 @@ jobs:
     - name: Install dependencies
       run: {{installDepsCommand}}
     - name: Install Playwright Browsers
-      run: npx playwright install --with-deps
+      run: {{installPlaywrightCommand}}
     - name: Run Playwright tests
       run: {{runTestsCommand}}
     - uses: actions/upload-artifact@v3

src/generator.ts

@@ -155,6 +155,7 @@ export class Generator {
     if (answers.installGitHubActions) {
       const githubActionsScript = executeTemplate(this._readAsset('github-actions.yml'), {
         installDepsCommand: packageManager.ci(),
+        installPlaywrightCommand: packageManager.npx('playwright', 'install --with-deps'),
         runTestsCommand: packageManager.runPlaywrightTest(),
       }, new Map());
       files.set('.github/workflows/playwright.yml', githubActionsScript);

tests/baseFixtures.ts

@@ -54,21 +54,16 @@ function spawnAsync(cmd: string, args: string[], options?: SpawnOptionsWithoutSt
 }
 
 export const test = base.extend<TestFixtures>({
-  packageManager: 'npm',
+  packageManager: ['npm', { option: true }],
   run: async ({ packageManager }, use, testInfo) => {
     await use(async (parameters: string[], options: PromptOptions): Promise<RunResult> => {
       fs.mkdirSync(testInfo.outputDir, { recursive: true });
-      const env = packageManager === 'yarn' ? {
-        'npm_config_user_agent': 'yarn'
-      } : packageManager === 'pnpm' ? {
-        'npm_config_user_agent': 'pnpm/0.0.0'
-      } : undefined;
       const result = await spawnAsync('node', [path.join(__dirname, '..'), ...parameters], {
         shell: true,
         cwd: testInfo.outputDir,
         env: {
           ...process.env,
-          ...env,
+          'npm_config_user_agent': packageManager === 'yarn' ? 'yarn' : packageManager === 'pnpm' ? 'pnpm/0.0.0' : undefined,
           'TEST_OPTIONS': JSON.stringify(options),
         }
       });