Skip to content

PS: Mark certain environment variables as not user controlled #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MathiasVP
Copy link
Collaborator

@chanel-y made an observation that I feel like I've only seen while reviewing some PowerShell query results: Certain environment variables are used very commonly, and they likely shouldn't be considered user input.

In 3a66283 you can see which environment variables I decided on excluding. @chanel-y I'd love to hear your thoughts on that list. In particular:

  • Should we simply exclude any environment variable? Or should we only exclude the "known good ones" as I'm doing here?
  • Are there any environment variables in the list that you feel like we shouldn't exclude?
  • Are there any environment variables in the list that we should exclude?

@MathiasVP MathiasVP marked this pull request as draft July 16, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant