Skip to content

Commit fee6373

Browse files
authored
Merge pull request #156 from microsoft/update-powershell-dataflow-after-shared-changes
Powershell: Fix dataflow library after GitHub changes
2 parents 547b562 + 273738e commit fee6373

File tree

3 files changed

+14
-3
lines changed

3 files changed

+14
-3
lines changed

powershell/ql/lib/semmle/code/powershell/dataflow/internal/FlowSummaryImpl.qll

+10
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,14 @@ private import DataFlowImplSpecific::Private
1010
private import DataFlowImplSpecific::Public
1111

1212
module Input implements InputSig<Location, DataFlowImplSpecific::PowershellDataFlow> {
13+
private import codeql.util.Void
14+
1315
class SummarizedCallableBase = string;
1416

17+
class SourceBase = Void;
18+
19+
class SinkBase = Void;
20+
1521
ArgumentPosition callbackSelfParameterPosition() { none() }
1622

1723
ReturnKind getStandardReturnValueKind() { result instanceof NormalReturnKind }
@@ -114,6 +120,10 @@ private module StepsInput implements Impl::Private::StepsInputSig {
114120
or
115121
result.asCall().getAstNode() = sc.(LibraryCallable).getACallSimple()
116122
}
123+
124+
Node getSourceNode(Input::SourceBase source, Impl::Private::SummaryComponent sc) { none() }
125+
126+
Node getSinkNode(Input::SinkBase source, Impl::Private::SummaryComponent sc) { none() }
117127
}
118128

119129
module Private {

powershell/ql/lib/semmle/code/powershell/typetracking/TypeTracking.qll

+2-1
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,6 @@
33
* for tracking types.
44
*/
55

6+
private import powershell
67
private import semmle.code.powershell.typetracking.internal.TypeTrackingImpl as Impl
7-
import Impl::Shared::TypeTracking<Impl::TypeTrackingInput>
8+
import Impl::Shared::TypeTracking<Location, Impl::TypeTrackingInput>

powershell/ql/lib/semmle/code/powershell/typetracking/internal/TypeTrackingImpl.qll

+2-2
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ private module TypeTrackerSummaryFlow = SummaryTypeTracker::SummaryFlow<SummaryT
157157

158158
private newtype TContentFilter = MkElementFilter()
159159

160-
module TypeTrackingInput implements Shared::TypeTrackingInput {
160+
module TypeTrackingInput implements Shared::TypeTrackingInput<Location> {
161161
class Node = DataFlowPublic::Node;
162162

163163
class LocalSourceNode = DataFlowPublic::LocalSourceNode;
@@ -295,4 +295,4 @@ module TypeTrackingInput implements Shared::TypeTrackingInput {
295295
predicate hasFeatureBacktrackStoreTarget() { none() }
296296
}
297297

298-
import SharedImpl::TypeTracking<TypeTrackingInput>
298+
import SharedImpl::TypeTracking<Location, TypeTrackingInput>

0 commit comments

Comments
 (0)