Skip to content

Commit 3903f32

Browse files
johnbattyjohnbatty
authored
Re-fix formatting of date-time parameters (#619)
1 parent 61404a2 commit 3903f32

File tree

10 files changed

+136
-62
lines changed

10 files changed

+136
-62
lines changed

‎autorust/codegen/src/codegen_operations/set_request_param_code.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,11 @@ impl ToTokens for SetRequestParamsCode {
5151
quote! {
5252
req.url_mut().query_pairs_mut().append_pair(#param_name, #param_name_var);
5353
}
54+
} else if param.type_name.is_date_time() {
55+
quote! {
56+
let formatted_date_time = crate::date_time::format_date_time(#param_name_var)?;
57+
req.url_mut().query_pairs_mut().append_pair(#param_name, &formatted_date_time);
58+
}
5459
} else {
5560
quote! {
5661
req.url_mut().query_pairs_mut().append_pair(#param_name, &#param_name_var.to_string());

‎azure_devops_rust_api/src/audit/mod.rs

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -434,14 +434,17 @@ pub mod audit_log {
434434
);
435435
}
436436
if let Some(start_time) = &this.start_time {
437+
let formatted_date_time =
438+
crate::date_time::format_date_time(start_time)?;
437439
req.url_mut()
438440
.query_pairs_mut()
439-
.append_pair("startTime", &start_time.to_string());
441+
.append_pair("startTime", &formatted_date_time);
440442
}
441443
if let Some(end_time) = &this.end_time {
444+
let formatted_date_time = crate::date_time::format_date_time(end_time)?;
442445
req.url_mut()
443446
.query_pairs_mut()
444-
.append_pair("endTime", &end_time.to_string());
447+
.append_pair("endTime", &formatted_date_time);
445448
}
446449
if let Some(batch_size) = &this.batch_size {
447450
req.url_mut()
@@ -624,14 +627,17 @@ pub mod download_log {
624627
.query_pairs_mut()
625628
.append_pair("format", format);
626629
if let Some(start_time) = &this.start_time {
630+
let formatted_date_time =
631+
crate::date_time::format_date_time(start_time)?;
627632
req.url_mut()
628633
.query_pairs_mut()
629-
.append_pair("startTime", &start_time.to_string());
634+
.append_pair("startTime", &formatted_date_time);
630635
}
631636
if let Some(end_time) = &this.end_time {
637+
let formatted_date_time = crate::date_time::format_date_time(end_time)?;
632638
req.url_mut()
633639
.query_pairs_mut()
634-
.append_pair("endTime", &end_time.to_string());
640+
.append_pair("endTime", &formatted_date_time);
635641
}
636642
let req_body = azure_core::Bytes::new();
637643
req.set_body(req_body);

‎azure_devops_rust_api/src/build/mod.rs

Lines changed: 25 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3654,14 +3654,16 @@ pub mod builds {
36543654
.append_pair("buildNumber", build_number);
36553655
}
36563656
if let Some(min_time) = &this.min_time {
3657+
let formatted_date_time = crate::date_time::format_date_time(min_time)?;
36573658
req.url_mut()
36583659
.query_pairs_mut()
3659-
.append_pair("minTime", &min_time.to_string());
3660+
.append_pair("minTime", &formatted_date_time);
36603661
}
36613662
if let Some(max_time) = &this.max_time {
3663+
let formatted_date_time = crate::date_time::format_date_time(max_time)?;
36623664
req.url_mut()
36633665
.query_pairs_mut()
3664-
.append_pair("maxTime", &max_time.to_string());
3666+
.append_pair("maxTime", &formatted_date_time);
36653667
}
36663668
if let Some(requested_for) = &this.requested_for {
36673669
req.url_mut()
@@ -9167,9 +9169,11 @@ pub mod definitions {
91679169
.append_pair("continuationToken", continuation_token);
91689170
}
91699171
if let Some(min_metrics_time) = &this.min_metrics_time {
9172+
let formatted_date_time =
9173+
crate::date_time::format_date_time(min_metrics_time)?;
91709174
req.url_mut()
91719175
.query_pairs_mut()
9172-
.append_pair("minMetricsTime", &min_metrics_time.to_string());
9176+
.append_pair("minMetricsTime", &formatted_date_time);
91739177
}
91749178
if let Some(definition_ids) = &this.definition_ids {
91759179
req.url_mut()
@@ -9180,14 +9184,18 @@ pub mod definitions {
91809184
req.url_mut().query_pairs_mut().append_pair("path", path);
91819185
}
91829186
if let Some(built_after) = &this.built_after {
9187+
let formatted_date_time =
9188+
crate::date_time::format_date_time(built_after)?;
91839189
req.url_mut()
91849190
.query_pairs_mut()
9185-
.append_pair("builtAfter", &built_after.to_string());
9191+
.append_pair("builtAfter", &formatted_date_time);
91869192
}
91879193
if let Some(not_built_after) = &this.not_built_after {
9194+
let formatted_date_time =
9195+
crate::date_time::format_date_time(not_built_after)?;
91889196
req.url_mut()
91899197
.query_pairs_mut()
9190-
.append_pair("notBuiltAfter", &not_built_after.to_string());
9198+
.append_pair("notBuiltAfter", &formatted_date_time);
91919199
}
91929200
if let Some(include_all_properties) = &this.include_all_properties {
91939201
req.url_mut().query_pairs_mut().append_pair(
@@ -9525,9 +9533,11 @@ pub mod definitions {
95259533
.append_pair("revision", &revision.to_string());
95269534
}
95279535
if let Some(min_metrics_time) = &this.min_metrics_time {
9536+
let formatted_date_time =
9537+
crate::date_time::format_date_time(min_metrics_time)?;
95289538
req.url_mut()
95299539
.query_pairs_mut()
9530-
.append_pair("minMetricsTime", &min_metrics_time.to_string());
9540+
.append_pair("minMetricsTime", &formatted_date_time);
95319541
}
95329542
if let Some(property_filters) = &this.property_filters {
95339543
req.url_mut()
@@ -10255,9 +10265,11 @@ pub mod metrics {
1025510265
);
1025610266
}
1025710267
if let Some(min_metrics_time) = &this.min_metrics_time {
10268+
let formatted_date_time =
10269+
crate::date_time::format_date_time(min_metrics_time)?;
1025810270
req.url_mut()
1025910271
.query_pairs_mut()
10260-
.append_pair("minMetricsTime", &min_metrics_time.to_string());
10272+
.append_pair("minMetricsTime", &formatted_date_time);
1026110273
}
1026210274
let req_body = azure_core::Bytes::new();
1026310275
req.set_body(req_body);
@@ -10394,9 +10406,11 @@ pub mod metrics {
1039410406
);
1039510407
}
1039610408
if let Some(min_metrics_time) = &this.min_metrics_time {
10409+
let formatted_date_time =
10410+
crate::date_time::format_date_time(min_metrics_time)?;
1039710411
req.url_mut()
1039810412
.query_pairs_mut()
10399-
.append_pair("minMetricsTime", &min_metrics_time.to_string());
10413+
.append_pair("minMetricsTime", &formatted_date_time);
1040010414
}
1040110415
let req_body = azure_core::Bytes::new();
1040210416
req.set_body(req_body);
@@ -10889,9 +10903,11 @@ pub mod yaml {
1088910903
.append_pair("revision", &revision.to_string());
1089010904
}
1089110905
if let Some(min_metrics_time) = &this.min_metrics_time {
10906+
let formatted_date_time =
10907+
crate::date_time::format_date_time(min_metrics_time)?;
1089210908
req.url_mut()
1089310909
.query_pairs_mut()
10894-
.append_pair("minMetricsTime", &min_metrics_time.to_string());
10910+
.append_pair("minMetricsTime", &formatted_date_time);
1089510911
}
1089610912
if let Some(property_filters) = &this.property_filters {
1089710913
req.url_mut()

‎azure_devops_rust_api/src/distributed_task/mod.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9452,9 +9452,11 @@ pub mod taskgroups {
94529452
.append_pair("$top", &top.to_string());
94539453
}
94549454
if let Some(continuation_token) = &this.continuation_token {
9455+
let formatted_date_time =
9456+
crate::date_time::format_date_time(continuation_token)?;
94559457
req.url_mut()
94569458
.query_pairs_mut()
9457-
.append_pair("continuationToken", &continuation_token.to_string());
9459+
.append_pair("continuationToken", &formatted_date_time);
94589460
}
94599461
if let Some(query_order) = &this.query_order {
94609462
req.url_mut()

‎azure_devops_rust_api/src/git/mod.rs

Lines changed: 30 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -5344,16 +5344,18 @@ pub mod pull_requests {
53445344
);
53455345
}
53465346
if let Some(search_criteria_max_time) = &this.search_criteria_max_time {
5347-
req.url_mut().query_pairs_mut().append_pair(
5348-
"searchCriteria.maxTime",
5349-
&search_criteria_max_time.to_string(),
5350-
);
5347+
let formatted_date_time =
5348+
crate::date_time::format_date_time(search_criteria_max_time)?;
5349+
req.url_mut()
5350+
.query_pairs_mut()
5351+
.append_pair("searchCriteria.maxTime", &formatted_date_time);
53515352
}
53525353
if let Some(search_criteria_min_time) = &this.search_criteria_min_time {
5353-
req.url_mut().query_pairs_mut().append_pair(
5354-
"searchCriteria.minTime",
5355-
&search_criteria_min_time.to_string(),
5356-
);
5354+
let formatted_date_time =
5355+
crate::date_time::format_date_time(search_criteria_min_time)?;
5356+
req.url_mut()
5357+
.query_pairs_mut()
5358+
.append_pair("searchCriteria.minTime", &formatted_date_time);
53575359
}
53585360
if let Some(search_criteria_query_time_range_type) =
53595361
&this.search_criteria_query_time_range_type
@@ -5804,16 +5806,18 @@ pub mod pull_requests {
58045806
);
58055807
}
58065808
if let Some(search_criteria_max_time) = &this.search_criteria_max_time {
5807-
req.url_mut().query_pairs_mut().append_pair(
5808-
"searchCriteria.maxTime",
5809-
&search_criteria_max_time.to_string(),
5810-
);
5809+
let formatted_date_time =
5810+
crate::date_time::format_date_time(search_criteria_max_time)?;
5811+
req.url_mut()
5812+
.query_pairs_mut()
5813+
.append_pair("searchCriteria.maxTime", &formatted_date_time);
58115814
}
58125815
if let Some(search_criteria_min_time) = &this.search_criteria_min_time {
5813-
req.url_mut().query_pairs_mut().append_pair(
5814-
"searchCriteria.minTime",
5815-
&search_criteria_min_time.to_string(),
5816-
);
5816+
let formatted_date_time =
5817+
crate::date_time::format_date_time(search_criteria_min_time)?;
5818+
req.url_mut()
5819+
.query_pairs_mut()
5820+
.append_pair("searchCriteria.minTime", &formatted_date_time);
58175821
}
58185822
if let Some(search_criteria_query_time_range_type) =
58195823
&this.search_criteria_query_time_range_type
@@ -16617,10 +16621,11 @@ pub mod pushes {
1661716621
.append_pair("$top", &top.to_string());
1661816622
}
1661916623
if let Some(search_criteria_from_date) = &this.search_criteria_from_date {
16620-
req.url_mut().query_pairs_mut().append_pair(
16621-
"searchCriteria.fromDate",
16622-
&search_criteria_from_date.to_string(),
16623-
);
16624+
let formatted_date_time =
16625+
crate::date_time::format_date_time(search_criteria_from_date)?;
16626+
req.url_mut()
16627+
.query_pairs_mut()
16628+
.append_pair("searchCriteria.fromDate", &formatted_date_time);
1662416629
}
1662516630
if let Some(search_criteria_include_links) =
1662616631
&this.search_criteria_include_links
@@ -16649,10 +16654,11 @@ pub mod pushes {
1664916654
.append_pair("searchCriteria.refName", search_criteria_ref_name);
1665016655
}
1665116656
if let Some(search_criteria_to_date) = &this.search_criteria_to_date {
16652-
req.url_mut().query_pairs_mut().append_pair(
16653-
"searchCriteria.toDate",
16654-
&search_criteria_to_date.to_string(),
16655-
);
16657+
let formatted_date_time =
16658+
crate::date_time::format_date_time(search_criteria_to_date)?;
16659+
req.url_mut()
16660+
.query_pairs_mut()
16661+
.append_pair("searchCriteria.toDate", &formatted_date_time);
1665616662
}
1665716663
let req_body = azure_core::Bytes::new();
1665816664
req.set_body(req_body);

‎azure_devops_rust_api/src/release/mod.rs

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -820,14 +820,18 @@ pub mod releases {
820820
);
821821
}
822822
if let Some(min_created_time) = &this.min_created_time {
823+
let formatted_date_time =
824+
crate::date_time::format_date_time(min_created_time)?;
823825
req.url_mut()
824826
.query_pairs_mut()
825-
.append_pair("minCreatedTime", &min_created_time.to_string());
827+
.append_pair("minCreatedTime", &formatted_date_time);
826828
}
827829
if let Some(max_created_time) = &this.max_created_time {
830+
let formatted_date_time =
831+
crate::date_time::format_date_time(max_created_time)?;
828832
req.url_mut()
829833
.query_pairs_mut()
830-
.append_pair("maxCreatedTime", &max_created_time.to_string());
834+
.append_pair("maxCreatedTime", &formatted_date_time);
831835
}
832836
if let Some(query_order) = &this.query_order {
833837
req.url_mut()
@@ -3808,14 +3812,18 @@ pub mod deployments {
38083812
.append_pair("createdBy", created_by);
38093813
}
38103814
if let Some(min_modified_time) = &this.min_modified_time {
3815+
let formatted_date_time =
3816+
crate::date_time::format_date_time(min_modified_time)?;
38113817
req.url_mut()
38123818
.query_pairs_mut()
3813-
.append_pair("minModifiedTime", &min_modified_time.to_string());
3819+
.append_pair("minModifiedTime", &formatted_date_time);
38143820
}
38153821
if let Some(max_modified_time) = &this.max_modified_time {
3822+
let formatted_date_time =
3823+
crate::date_time::format_date_time(max_modified_time)?;
38163824
req.url_mut()
38173825
.query_pairs_mut()
3818-
.append_pair("maxModifiedTime", &max_modified_time.to_string());
3826+
.append_pair("maxModifiedTime", &formatted_date_time);
38193827
}
38203828
if let Some(deployment_status) = &this.deployment_status {
38213829
req.url_mut()
@@ -3854,14 +3862,18 @@ pub mod deployments {
38543862
.append_pair("createdFor", created_for);
38553863
}
38563864
if let Some(min_started_time) = &this.min_started_time {
3865+
let formatted_date_time =
3866+
crate::date_time::format_date_time(min_started_time)?;
38573867
req.url_mut()
38583868
.query_pairs_mut()
3859-
.append_pair("minStartedTime", &min_started_time.to_string());
3869+
.append_pair("minStartedTime", &formatted_date_time);
38603870
}
38613871
if let Some(max_started_time) = &this.max_started_time {
3872+
let formatted_date_time =
3873+
crate::date_time::format_date_time(max_started_time)?;
38623874
req.url_mut()
38633875
.query_pairs_mut()
3864-
.append_pair("maxStartedTime", &max_started_time.to_string());
3876+
.append_pair("maxStartedTime", &formatted_date_time);
38653877
}
38663878
if let Some(source_branch) = &this.source_branch {
38673879
req.url_mut()

0 commit comments

Comments
 (0)