Struct GraphGroup does not export isDeleted property

[tmeckel]

While authoring acceptance tests for the Azure DevOps Terraform provider I discovered that type GraphGroup struct does not export the isDeleted property.

The acceptance test requires a check if a created group has been removed (deleted) by the destroy operation of Terraform. The issue is that a call to GetGroup of the Graph client the group is still returned so the acceptance test still assumes that the group was not destroyed and thus consequently fails. If the isDeleted property would be available in the struct, the implementation can check the state of the property to verify a successful destruction aside that the GetGroup method returns nil.

@nmiodice

[tedchamb]

@tmeckel , the team that owns this REST area has marked that property as for InternalUseOnly, so the generator ignores it. Your best bet is to ask the team directly what the best way is to get the data you are looking for.

You can post questions to them here:
https://docs.microsoft.com/en-us/rest/api/azure/devops/graph/?view=azure-devops-rest-5.1

[tmeckel]

@tedchamb As explicitly stated in the documentation, a group is returned by the REST API even if it has been deleted.

For this reason, the flag isDeleted exists to indicate whether the group has already been deleted and thus the caller is able to detect a deleted group. In the current implementation of the GO API, it is never evident to the caller whether a group has been deleted or not, when it was loaded directly via the GET method of the REST API, since the GO implementation does not provide this flag.

Hence I assume that marking this attribute as INTERNAL is a bug.

If you know another way to detect if a group has been deleted than checking the isDeleted flag (well, except loading all groups and check if the group in question isn't listed anymore) I'm happy to take this path.

[tedchamb]

@tmeckel, it may be a bug. See my comment above, on how to contact the team that owns the api. They are the ones that will need to fix this in the Azure DevOps code, before the generator will generate this property in both the Go SDK and the documentation. I will also try and contact the team directly, but posting issues in the link I sent above is the correct way to report this issue to them.

[tmeckel]

@tedchamb Okay, let's tackle this from both side then 😏

https://developercommunity.visualstudio.com/content/problem/870642/graph-api-graphgroup-property-isdeleted-hidden-mar.html

[nmiodice]

Unfortunately the developer community issue has been closed :/ cc @mozehgir

[tmeckel]

@nmiodice thank you for commenting on this issue on the developer community site for Azure DevOps. Perhaps @mozehgir and you (perhaps @tedchamb as well?) might talk to someone in the product group to get them convinced that the current situation isn't ideal for people using the API. I think I made my position clear this in my older comments here.