Skip to content

Commit 00dac5c

Browse files
nechvatalpnechvatalp
authored
Merge pull request #113 from andyliuliming/andliu/fixtimeissue
Fix incorrect value for azuredevops.Time when using in query parameter
2 parents 0974d01 + 2cbb898 commit 00dac5c

File tree

5 files changed

+21
-21
lines changed

5 files changed

+21
-21
lines changed

‎azuredevops/v6/audit/client.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,10 +121,10 @@ func (client *ClientImpl) DownloadLog(ctx context.Context, args DownloadLogArgs)
121121
}
122122
queryParams.Add("format", *args.Format)
123123
if args.StartTime != nil {
124-
queryParams.Add("startTime", (*args.StartTime).String())
124+
queryParams.Add("startTime", (*args.StartTime).AsQueryParameter())
125125
}
126126
if args.EndTime != nil {
127-
queryParams.Add("endTime", (*args.EndTime).String())
127+
queryParams.Add("endTime", (*args.EndTime).AsQueryParameter())
128128
}
129129
locationId, _ := uuid.Parse("b7b98a76-04e8-4f4d-ac72-9d46492caaac")
130130
resp, err := client.Client.Send(ctx, http.MethodGet, locationId, "6.0-preview.1", nil, queryParams, nil, "", "application/octet-stream", nil)
@@ -189,10 +189,10 @@ type QueryAllStreamsArgs struct {
189189
func (client *ClientImpl) QueryLog(ctx context.Context, args QueryLogArgs) (*AuditLogQueryResult, error) {
190190
queryParams := url.Values{}
191191
if args.StartTime != nil {
192-
queryParams.Add("startTime", (*args.StartTime).String())
192+
queryParams.Add("startTime", (*args.StartTime).AsQueryParameter())
193193
}
194194
if args.EndTime != nil {
195-
queryParams.Add("endTime", (*args.EndTime).String())
195+
queryParams.Add("endTime", (*args.EndTime).AsQueryParameter())
196196
}
197197
if args.BatchSize != nil {
198198
queryParams.Add("batchSize", strconv.Itoa(*args.BatchSize))

‎azuredevops/v6/build/client.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1672,10 +1672,10 @@ func (client *ClientImpl) GetBuilds(ctx context.Context, args GetBuildsArgs) (*G
16721672
queryParams.Add("buildNumber", *args.BuildNumber)
16731673
}
16741674
if args.MinTime != nil {
1675-
queryParams.Add("minTime", (*args.MinTime).String())
1675+
queryParams.Add("minTime", (*args.MinTime).AsQueryParameter())
16761676
}
16771677
if args.MaxTime != nil {
1678-
queryParams.Add("maxTime", (*args.MaxTime).String())
1678+
queryParams.Add("maxTime", (*args.MaxTime).AsQueryParameter())
16791679
}
16801680
if args.RequestedFor != nil {
16811681
queryParams.Add("requestedFor", *args.RequestedFor)
@@ -2036,7 +2036,7 @@ func (client *ClientImpl) GetDefinition(ctx context.Context, args GetDefinitionA
20362036
queryParams.Add("revision", strconv.Itoa(*args.Revision))
20372037
}
20382038
if args.MinMetricsTime != nil {
2039-
queryParams.Add("minMetricsTime", (*args.MinMetricsTime).String())
2039+
queryParams.Add("minMetricsTime", (*args.MinMetricsTime).AsQueryParameter())
20402040
}
20412041
if args.PropertyFilters != nil {
20422042
listAsString := strings.Join((*args.PropertyFilters)[:], ",")
@@ -2086,7 +2086,7 @@ func (client *ClientImpl) GetDefinitionMetrics(ctx context.Context, args GetDefi
20862086

20872087
queryParams := url.Values{}
20882088
if args.MinMetricsTime != nil {
2089-
queryParams.Add("minMetricsTime", (*args.MinMetricsTime).String())
2089+
queryParams.Add("minMetricsTime", (*args.MinMetricsTime).AsQueryParameter())
20902090
}
20912091
locationId, _ := uuid.Parse("d973b939-0ce0-4fec-91d8-da3940fa1827")
20922092
resp, err := client.Client.Send(ctx, http.MethodGet, locationId, "6.0-preview.1", routeValues, queryParams, nil, "", "application/json", nil)
@@ -2237,7 +2237,7 @@ func (client *ClientImpl) GetDefinitions(ctx context.Context, args GetDefinition
22372237
queryParams.Add("continuationToken", *args.ContinuationToken)
22382238
}
22392239
if args.MinMetricsTime != nil {
2240-
queryParams.Add("minMetricsTime", (*args.MinMetricsTime).String())
2240+
queryParams.Add("minMetricsTime", (*args.MinMetricsTime).AsQueryParameter())
22412241
}
22422242
if args.DefinitionIds != nil {
22432243
var stringList []string
@@ -2600,7 +2600,7 @@ func (client *ClientImpl) GetProjectMetrics(ctx context.Context, args GetProject
26002600

26012601
queryParams := url.Values{}
26022602
if args.MinMetricsTime != nil {
2603-
queryParams.Add("minMetricsTime", (*args.MinMetricsTime).String())
2603+
queryParams.Add("minMetricsTime", (*args.MinMetricsTime).AsQueryParameter())
26042604
}
26052605
locationId, _ := uuid.Parse("7433fae7-a6bc-41dc-a6e2-eef9005ce41a")
26062606
resp, err := client.Client.Send(ctx, http.MethodGet, locationId, "6.0-preview.1", routeValues, queryParams, nil, "", "application/json", nil)

‎azuredevops/v6/notification/client.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -289,10 +289,10 @@ func (client *ClientImpl) ListLogs(ctx context.Context, args ListLogsArgs) (*[]I
289289

290290
queryParams := url.Values{}
291291
if args.StartTime != nil {
292-
queryParams.Add("startTime", (*args.StartTime).String())
292+
queryParams.Add("startTime", (*args.StartTime).AsQueryParameter())
293293
}
294294
if args.EndTime != nil {
295-
queryParams.Add("endTime", (*args.EndTime).String())
295+
queryParams.Add("endTime", (*args.EndTime).AsQueryParameter())
296296
}
297297
locationId, _ := uuid.Parse("991842f3-eb16-4aea-ac81-81353ef2b75c")
298298
resp, err := client.Client.Send(ctx, http.MethodGet, locationId, "6.0", routeValues, queryParams, nil, "", "application/json", nil)

‎azuredevops/v6/release/client.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -401,10 +401,10 @@ func (client *ClientImpl) GetDeployments(ctx context.Context, args GetDeployment
401401
queryParams.Add("createdBy", *args.CreatedBy)
402402
}
403403
if args.MinModifiedTime != nil {
404-
queryParams.Add("minModifiedTime", (*args.MinModifiedTime).String())
404+
queryParams.Add("minModifiedTime", (*args.MinModifiedTime).AsQueryParameter())
405405
}
406406
if args.MaxModifiedTime != nil {
407-
queryParams.Add("maxModifiedTime", (*args.MaxModifiedTime).String())
407+
queryParams.Add("maxModifiedTime", (*args.MaxModifiedTime).AsQueryParameter())
408408
}
409409
if args.DeploymentStatus != nil {
410410
queryParams.Add("deploymentStatus", string(*args.DeploymentStatus))
@@ -428,10 +428,10 @@ func (client *ClientImpl) GetDeployments(ctx context.Context, args GetDeployment
428428
queryParams.Add("createdFor", *args.CreatedFor)
429429
}
430430
if args.MinStartedTime != nil {
431-
queryParams.Add("minStartedTime", (*args.MinStartedTime).String())
431+
queryParams.Add("minStartedTime", (*args.MinStartedTime).AsQueryParameter())
432432
}
433433
if args.MaxStartedTime != nil {
434-
queryParams.Add("maxStartedTime", (*args.MaxStartedTime).String())
434+
queryParams.Add("maxStartedTime", (*args.MaxStartedTime).AsQueryParameter())
435435
}
436436
if args.SourceBranch != nil {
437437
queryParams.Add("sourceBranch", *args.SourceBranch)
@@ -951,10 +951,10 @@ func (client *ClientImpl) GetReleases(ctx context.Context, args GetReleasesArgs)
951951
queryParams.Add("environmentStatusFilter", strconv.Itoa(*args.EnvironmentStatusFilter))
952952
}
953953
if args.MinCreatedTime != nil {
954-
queryParams.Add("minCreatedTime", (*args.MinCreatedTime).String())
954+
queryParams.Add("minCreatedTime", (*args.MinCreatedTime).AsQueryParameter())
955955
}
956956
if args.MaxCreatedTime != nil {
957-
queryParams.Add("maxCreatedTime", (*args.MaxCreatedTime).String())
957+
queryParams.Add("maxCreatedTime", (*args.MaxCreatedTime).AsQueryParameter())
958958
}
959959
if args.QueryOrder != nil {
960960
queryParams.Add("queryOrder", string(*args.QueryOrder))

‎azuredevops/v6/workitemtracking/client.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1756,7 +1756,7 @@ func (client *ClientImpl) GetReportingLinksByLinkType(ctx context.Context, args
17561756
queryParams.Add("continuationToken", *args.ContinuationToken)
17571757
}
17581758
if args.StartDateTime != nil {
1759-
queryParams.Add("startDateTime", (*args.StartDateTime).String())
1759+
queryParams.Add("startDateTime", (*args.StartDateTime).AsQueryParameter())
17601760
}
17611761
locationId, _ := uuid.Parse("b5b5b6d0-0308-40a1-b3f4-b9bb3c66878f")
17621762
resp, err := client.Client.Send(ctx, http.MethodGet, locationId, "6.0", routeValues, queryParams, nil, "", "application/json", nil)
@@ -2905,7 +2905,7 @@ func (client *ClientImpl) ReadReportingRevisionsGet(ctx context.Context, args Re
29052905
queryParams.Add("continuationToken", *args.ContinuationToken)
29062906
}
29072907
if args.StartDateTime != nil {
2908-
queryParams.Add("startDateTime", (*args.StartDateTime).String())
2908+
queryParams.Add("startDateTime", (*args.StartDateTime).AsQueryParameter())
29092909
}
29102910
if args.IncludeIdentityRef != nil {
29112911
queryParams.Add("includeIdentityRef", strconv.FormatBool(*args.IncludeIdentityRef))
@@ -2982,7 +2982,7 @@ func (client *ClientImpl) ReadReportingRevisionsPost(ctx context.Context, args R
29822982
queryParams.Add("continuationToken", *args.ContinuationToken)
29832983
}
29842984
if args.StartDateTime != nil {
2985-
queryParams.Add("startDateTime", (*args.StartDateTime).String())
2985+
queryParams.Add("startDateTime", (*args.StartDateTime).AsQueryParameter())
29862986
}
29872987
if args.Expand != nil {
29882988
queryParams.Add("$expand", string(*args.Expand))

0 commit comments

Comments
 (0)