Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in AgentRuntime.cs RpcRequest scp update() #4635

Closed
rysweet opened this issue Dec 10, 2024 · 0 comments · Fixed by #4636
Closed

Bug in AgentRuntime.cs RpcRequest scp update() #4635

rysweet opened this issue Dec 10, 2024 · 0 comments · Fixed by #4636
Assignees
Labels
dotnet issues related to AutoGen.Net

Comments

@rysweet
Copy link
Collaborator

rysweet commented Dec 10, 2024

What happened?

public void Update(RpcRequest request, Activity? activity = null)
    {
        DistributedContextPropagator.Inject(activity, request.Metadata, static (carrier, key, value) => ((IDictionary<string, string>)carrier!)[key] = value);
    }

if key isn't already defined this will throw

What did you expect to happen?

safety!

How can we reproduce it (as minimally and precisely as possible)?

send an RpcRequest with no metadata

AutoGen version

0.4

Which package was this bug in

Core

Model used

No response

Python version

No response

Operating system

No response

Any additional info you think would be helpful for fixing this bug

No response

@rysweet rysweet added the dotnet issues related to AutoGen.Net label Dec 10, 2024
@rysweet rysweet self-assigned this Dec 10, 2024
@rysweet rysweet linked a pull request Dec 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet issues related to AutoGen.Net
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant