Salsa - incorrect error message when using ES7 decorators in a .js file

[egamma]

See the error message in the screen shot below. It is from a .js project that is using ES7 features using bable to downlevel compile it.

If I'm a bable user I consider the error message as wrong. I've tried to enable 'experimentalDecorators' in the jsconfig.json, but this didn't have any effect.

[egamma]

@billti This project is actually an interesting test case for Salsa, it uses webpack, bable, react, ES7 decorators, ES7 spread operator, and many other technologies (it is the one from the crash bug microsoft/vscode#2054)

To use it as a test case:

• git clone https://github.com/DelvarWorld/some-game.git
• npm install - not only installs node modules but also produces webpacks etc.

[billti]

Looks like we explicitly check for and error on decorators in a JavaScript file (at https://github.com/Microsoft/TypeScript/blob/master/src/compiler/program.ts#L1171 ). Not sure why. I'll get this removed and experiment with the project provided a little also. Thanks!

[egamma]

@billti thank you!

[JakeGinnivan]

@billti @egamma you mentioned spread operator. Is there any way to get salsa to recognise that syntax and not give me errors?

[billti]

@JakeGinnivan It's a much requested feature and on the radar, but not support yet. It's covered by #2103 (and please don't add more +1s to it... we have enough, we know you guys want it 😉 ).

[mikekidder]

-- Update 🎱 says my issue is this -- #7076, so you can ignore below -- 👍

Sorry to piggyback on the Issue, but on testing latest version of VSCode/Typescript/Salsa: Does a project require a jsconfig.json for it to recognize import { someExport } from 'whatever'; in your JS files?

If not, still getting Parsing error: The keyword 'import' is reserved (null) message. I can open separate issue.

[egamma]

@mikekidder

If not, still getting Parsing error: The keyword 'import' is reserved (null) message. I can open separate issue.

I think you have eslint enabled and this error message comes from eslint. To enable imports in eslint you need to enable sourcetype: module in the .eslintrc.json, pls see this gist for an example: https://gist.github.com/egamma/65c0e2a832393e3b625a