Feb 2019 Definitely Typed failures on typescript@next

[sandersn]

Found by trying to change a whole bunch of package's project URLs in DefinitelyTyped/DefinitelyTyped#32977

d3-array

Error: C:/Users/nathansa/DefinitelyTyped/types/d3-array/d3-array-tests.ts:611:7
ERROR: 611:7  expect  TypeScript@next compile error:
Type '(string | number | number[] | Date)[]' is not assignable to type '(number[] | Date)[]'.
  Type 'string | number | number[] | Date' is not assignable to type 'number[] | Date'.
    Type 'string' is not assignable to type 'number[] | Date'.

Looks like a possible change in index access types

ember

Error: C:/Users/nathansa/DefinitelyTyped/types/ember/test/observable.ts:106:32
ERROR: 106:32  expect  TypeScript@next compile error:
Argument of type 'Pick<UnwrapComputedPropertyGetters<any>, string>' is not assignable to parameter of type '{ dummy: any; }'.
  Property 'dummy' is missing in type 'Pick<UnwrapComputedPropertyGetters<any>, string>' but required in type '{ dummy: any; }'.

Same.

petit-dom

Error: C:/Users/nathansa/DefinitelyTyped/types/petit-dom/petit-dom-tests.tsx:190:10
ERROR: 190:10  expect  TypeScript@next compile error:
Type '{ content: (string | Element)[]; name: string; count: number; onSomeEvent: (event: Event) => void; }' is not assignable to type 'IntrinsicAttributes & CustomProps'.
  Property 'content' does not exist on type 'IntrinsicAttributes & CustomProps'.
ERROR: 354:10  expect  TypeScript@next compile error:
Type '{ content: (string | Element)[]; name: string; count: number; onSomeEvent: (event: Event) => void; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<ComponentClassWithChildren> & CustomProps'.
  Property 'content' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<ComponentClassWithChildren> & CustomProps'.

Something to do with JSX? Not sure.

[sandersn]

@weswigham Mind taking a look? These all seem related to changes you have made or were discussing with Anders.

[weswigham]

Do we know what day these started failing in DT, so I can narrow down the cause?

[sandersn]

No, we don't have a regular DT run right now: https://typescript.visualstudio.com/TypeScript/_build?definitionId=15 is paused because it always times out. :(

[sandersn]

More failures from DefinitelyTyped/DefinitelyTyped#33038:

react-instantsearch-core

Error in react-instantsearch-core
Error: /home/nathansa/DefinitelyTyped/types/react-instantsearch-core/react-instantsearch-core-tests.tsx:111:49
ERROR: 111:49  expect  TypeScript@next compile error: 
Argument of type '({ additionalProp, searchResults }: StateResultsProps) => Element' is not assignable to parameter of type 'ComponentType<Partial<StateResultsProvided<{}>>>'.
  Type '({ additionalProp, searchResults }: StateResultsProps) => Element' is not assignable to type 'FunctionComponent<Partial<StateResultsProvided<{}>>>'.
    Types of parameters '__0' and 'props' are incompatible.
      Property 'additionalProp' is missing in type 'Partial<StateResultsProvided<{}>> & { children?: ReactNode; }' but required in type 'StateResultsProps'.
ERROR: 113:1   expect  TypeScript@next: Expected an error on this line, but found none.
ERROR: 130:51  expect  TypeScript@next compile error: 
Argument of type 'typeof MyComponent' is not assignable to parameter of type 'ComponentType<Partial<StateResultsProvided<{}>>>'.
  Type 'typeof MyComponent' is not assignable to type 'ComponentClass<Partial<StateResultsProvided<{}>>, any>'.
    Types of parameters 'props' and 'props' are incompatible.
      Property 'additionalProp' is missing in type 'Partial<StateResultsProvided<{}>>' but required in type 'Readonly<StateResultsProps>'.
ERROR: 132:1   expect  TypeScript@next: Expected an error on this line, but found none.

Not sure what is going on here.

ember, et al

There are about 9 ember packages that fail, all with the same set of 10 errors, all of which are similar. Here's an example:

../ember__array/proxy.d.ts(11,15): error TS2417: Class static side 'typeof ArrayProxy' incorrectly extends base class static side 'Readonly<typeof EmberObject>'.
  Types of property 'prototype' are incompatible.
    Type 'ArrayProxy<any>' is not assignable to type 'EmberObject'.
      Types of property 'getProperties' are incompatible.
        Type '{ <K extends "toString" | "indexOf" | "lastIndexOf" | "replace" | "slice" | "length" | "includes" | "map" | "filter" | "any" | "get" | "set" | "getProperties" | "setProperties" | "notifyPropertyChange" | ... 62 more ... | "removeObjects">(list: K[]): Pick<...>; <K extends "toString" | ... 76 more ... | "removeObject...' is not assignable to type '{ <K extends "toString" | "get" | "set" | "getProperties" | "setProperties" | "notifyPropertyChange" | "addObserver" | "removeObserver" | "getWithDefault" | "incrementProperty" | "decrementProperty" | ... 8 more ... | "willDestroy">(list: K[]): Pick<...>; <K extends "toString" | ... 18 more ... | "willDestroy">(...l...'.
          Type 'Pick<UnwrapComputedPropertyGetters<ArrayProxy<any>>, any>' is not assignable to type 'Pick<UnwrapComputedPropertyGetters<EmberObject>, any>'.
            Type 'UnwrapComputedPropertyGetters<ArrayProxy<any>>' is not assignable to type 'UnwrapComputedPropertyGetters<EmberObject>'.
              Types of property 'setProperties' are incompatible.
                Type '{ <K extends "toString" | "indexOf" | "lastIndexOf" | "replace" | "slice" | "length" | "includes" | "map" | "filter" | "any" | "get" | "set" | "getProperties" | "setProperties" | "notifyPropertyChange" | ... 62 more ... | "removeObjects">(hash: Pick<...>): Pick<...>; <K extends "toString" | ... 76 more ... | "remove...' is not assignable to type '{ <K extends "toString" | "get" | "set" | "getProperties" | "setProperties" | "notifyPropertyChange" | "addObserver" | "removeObserver" | "getWithDefault" | "incrementProperty" | "decrementProperty" | ... 8 more ... | "willDestroy">(hash: Pick<...>): Pick<...>; <K extends "toString" | ... 18 more ... | "willDestroy"...'.
                  Type 'Pick<UnwrapComputedPropertySetters<ArrayProxy<any>>, any>' is not assignable to type 'Pick<UnwrapComputedPropertySetters<EmberObject>, any>'.
                    Type 'UnwrapComputedPropertySetters<ArrayProxy<any>>' is not assignable to type 'UnwrapComputedPropertySetters<EmberObject>'.
                      Type 'EmberObject' is not assignable to type 'ArrayProxy<any>'.

Seems like it's related to the other ember error.

[Flarna]

it was green yesterday (see DefinitelyTyped/DefinitelyTyped#33011)

[mike-north]

FWIW the ember stuff wasn't showing these specific errors until the dev-20190213 3.4 build, although we were running into another issue that #29787 was intended to resolve.

[sandersn]

Found a few more in DefinitelyTyped/DefinitelyTyped#33051

baidu-app

Error in baidu-app
Error: /home/travis/build/DefinitelyTyped/DefinitelyTyped/types/baidu-app/index.d.ts:4290:20
ERROR: 4290:20  expect  TypeScript@next compile error: 
Type 'V' does not satisfy the constraint 'Component<Data | ((this: V) => Data), Props>'.
  Type 'Component<Data, Props>' is not assignable to type 'Component<Data | ((this: V) => Data), Props>'.
    Types of property 'data' are incompatible.
      Type '{ [key in keyof (Data & Props)]: DataValueType<(Data & Props)[key]>; }' is not assignable to type '{ [key in keyof ((Data & Props) | (((this: V) => Data) & Props))]: DataValueType<((Data & Props) | (((this: V) => Data) & Props))[key]>; }'.
        Type 'DataValueType<(Data & Props)[key]>' is not assignable to type 'DataValueType<((Data & Props) | (((this: V) => Data) & Props))[key]>'.

yargs

Error in yargs
Error: /home/travis/build/DefinitelyTyped/DefinitelyTyped/types/yargs/yargs-tests.ts:318:9
ERROR: 318:9   expect  TypeScript@next compile error: 
Type '(yargs: Argv<{ a: string; }>) => Argv<Omit<{ a: string; } & { b: number | undefined; }, "b"> & { b: number; }>' is not assignable to type '{ [key: string]: Options; } | ((args: Argv<{ a: string; }>) => Argv<{ b: number; }>) | undefined'.
  Type '(yargs: Argv<{ a: string; }>) => Argv<Omit<{ a: string; } & { b: number | undefined; }, "b"> & { b: number; }>' is not assignable to type '(args: Argv<{ a: string; }>) => Argv<{ b: number; }>'.
    Type 'Argv<Omit<{ a: string; } & { b: number | undefined; }, "b"> & { b: number; }>' is not assignable to type 'Argv<{ b: number; }>'.
      Types of property 'alias' are incompatible.
        Type '{ <K1 extends "b" | "a", K2 extends string>(shortName: K1, longName: K2 | readonly K2[]): Argv<Omit<{ a: string; } & { b: number | undefined; }, "b"> & { b: number; } & { [key in K2]: (Omit<{ a: string; } & { b: number | undefined; }, "b"> & { ...; })[K1]; }>; <K1 extends "b" | "a", K2 extends string>(shortName: K2,...' is not assignable to type '{ <K1 extends "b", K2 extends string>(shortName: K1, longName: K2 | readonly K2[]): Argv<{ b: number; } & { [key in K2]: { b: number; }[K1]; }>; <K1 extends "b", K2 extends string>(shortName: K2, longName: K1 | readonly K1[]): Argv<{ b: number; } & { [key in K2]: { ...; }[K1]; }>; (shortName: string | readonly strin...'.
          Type 'Argv<Omit<{ a: string; } & { b: number | undefined; }, "b"> & { b: number; } & { [x: string]: any; }>' is not assignable to type 'Argv<{ b: number; } & { [x: string]: any; }>'.
            Types of property 'alias' are incompatible.
              Type '{ <K1 extends any, K2 extends string>(shortName: K1, longName: K2 | readonly K2[]): Argv<Omit<{ a: string; } & { b: number | undefined; }, "b"> & { b: number; } & { [x: string]: any; } & { [key in K2]: (Omit<{ a: string; } & { b: number | undefined; }, "b"> & { ...; } & { ...; })[K1]; }>; <K1 extends any, K2 extends...' is not assignable to type '{ <K1 extends any, K2 extends string>(shortName: K1, longName: K2 | readonly K2[]): Argv<{ b: number; } & { [x: string]: any; } & { [key in K2]: ({ b: number; } & { [x: string]: any; })[K1]; }>; <K1 extends any, K2 extends string>(shortName: K2, longName: K1 | readonly K1[]): Argv<...>; (shortName: string | readonly...'.
                Type 'Argv<Omit<{ a: string; } & { b: number | undefined; }, "b"> & { b: number; } & { [x: string]: any; } & { [x: string]: any; }>' is not assignable to type 'Argv<{ b: number; } & { [x: string]: any; } & { [x: string]: any; }>'.
                  Types of property 'alias' are incompatible.
                    Type '{ <K1 extends any, K2 extends string>(shortName: K1, longName: K2 | readonly K2[]): Argv<Omit<{ a: string; } & { b: number | undefined; }, "b"> & { b: number; } & { [x: string]: any; } & { [x: string]: any; } & { [key in K2]: (Omit<{ a: string; } & { b: number | undefined; }, "b"> & { ...; } & { ...; } & { ...; })[K...' is not assignable to type '{ <K1 extends any, K2 extends string>(shortName: K1, longName: K2 | readonly K2[]): Argv<{ b: number; } & { [x: string]: any; } & { [x: string]: any; } & { [key in K2]: ({ b: number; } & { [x: string]: any; } & { [x: string]: any; })[K1]; }>; <K1 extends any, K2 extends string>(shortName: K2, longName: K1 | readonly...'.
                      Type 'Argv<Omit<{ a: string; } & { b: number | undefined; }, "b"> & { b: number; } & { [x: string]: any; } & { [x: string]: any; } & { [x: string]: any; }>' is not assignable to type 'Argv<{ b: number; } & { [x: string]: any; } & { [x: string]: any; } & { [x: string]: any; }>'.
                        Types of property 'command' are incompatible.
                          Type '{ <U>(command: string | readonly string[], description: string, builder?: ((args: Argv<Omit<{ a: string; } & { b: number | undefined; }, "b"> & { b: number; } & { [x: string]: any; } & { [x: string]: any; } & { [x: string]: any; }>) => Argv<...>) | undefined, handler?: ((args: Arguments<...>) => void) | undefined): ...' is not assignable to type '{ <U>(command: string | readonly string[], description: string, builder?: ((args: Argv<{ b: number; } & { [x: string]: any; } & { [x: string]: any; } & { [x: string]: any; }>) => Argv<U>) | undefined, handler?: ((args: Arguments<U>) => void) | undefined): Argv<...>; <O extends { ...; }>(command: string | readonly st...'.
                            Types of parameters 'module' and 'module' are incompatible.
                              Type 'CommandModule<{ b: number; } & { [x: string]: any; } & { [x: string]: any; } & { [x: string]: any; }, any>' is not assignable to type 'CommandModule<Omit<{ a: string; } & { b: number | undefined; }, "b"> & { b: number; } & { [x: string]: any; } & { [x: string]: any; } & { [x: string]: any; }, any>'.
                                Type '{ b: number; } & { [x: string]: any; } & { [x: string]: any; } & { [x: string]: any; }' is not assignable to type 'Omit<{ a: string; } & { b: number | undefined; }, "b"> & { b: number; } & { [x: string]: any; } & { [x: string]: any; } & { [x: string]: any; }'.
                                  Type '{ b: number; } & { [x: string]: any; } & { [x: string]: any; } & { [x: string]: any; }' is not assignable to type 'Omit<{ a: string; } & { b: number | undefined; }, "b">'.
ERROR: 383:11  expect  TypeScript@next compile error: 
Type '(yargs: Argv<{}>) => Argv<Omit<{ file: unknown; }, "cleanDestination"> & InferredOptionTypes<{ cleanDestination: { boolean: true; describe: string; }; }>>' is not assignable to type 'CommandBuilder<{}, {}>'.
  Type '(yargs: Argv<{}>) => Argv<Omit<{ file: unknown; }, "cleanDestination"> & InferredOptionTypes<{ cleanDestination: { boolean: true; describe: string; }; }>>' is not assignable to type '(args: Argv<{}>) => Argv<{}>'.
    Type 'Argv<Omit<{ file: unknown; }, "cleanDestination"> & InferredOptionTypes<{ cleanDestination: { boolean: true; describe: string; }; }>>' is not assignable to type 'Argv<{}>'.
      Types of property 'alias' are incompatible.
        Type '{ <K1 extends "file" | "cleanDestination", K2 extends string>(shortName: K1, longName: K2 | readonly K2[]): Argv<Omit<{ file: unknown; }, "cleanDestination"> & InferredOptionTypes<{ cleanDestination: { boolean: true; describe: string; }; }> & { [key in K2]: (Omit<...> & InferredOptionTypes<...>)[K1]; }>; <K1 extends...' is not assignable to type '{ <K1 extends never, K2 extends string>(shortName: K1, longName: K2 | readonly K2[]): Argv<{ [key in K2]: {}[K1]; }>; <K1 extends never, K2 extends string>(shortName: K2, longName: K1 | readonly K1[]): Argv<{ [key in K2]: {}[K1]; }>; (shortName: string | readonly string[], longName: string | readonly string[]): Argv...'.
          Type 'Argv<Omit<{ file: unknown; }, "cleanDestination"> & InferredOptionTypes<{ cleanDestination: { boolean: true; describe: string; }; }> & { [x: string]: any; }>' is not assignable to type 'Argv<{ [x: string]: any; }>'.
            Types of property 'alias' are incompatible.
              Type '{ <K1 extends any, K2 extends string>(shortName: K1, longName: K2 | readonly K2[]): Argv<Omit<{ file: unknown; }, "cleanDestination"> & InferredOptionTypes<{ cleanDestination: { boolean: true; describe: string; }; }> & { [x: string]: any; } & { [key in K2]: (Omit<...> & ... 1 more ... & { ...; })[K1]; }>; <K1 extend...' is not assignable to type '{ <K1 extends any, K2 extends string>(shortName: K1, longName: K2 | readonly K2[]): Argv<{ [x: string]: any; } & { [key in K2]: { [x: string]: any; }[K1]; }>; <K1 extends any, K2 extends string>(shortName: K2, longName: K1 | readonly K1[]): Argv<{ [x: string]: any; } & { [key in K2]: { ...; }[K1]; }>; (shortName: st...'.
                Type 'Argv<Omit<{ file: unknown; }, "cleanDestination"> & InferredOptionTypes<{ cleanDestination: { boolean: true; describe: string; }; }> & { [x: string]: any; } & { [x: string]: any; }>' is not assignable to type 'Argv<{ [x: string]: any; } & { [x: string]: any; }>'.
                  Types of property 'alias' are incompatible.
                    Type '{ <K1 extends any, K2 extends string>(shortName: K1, longName: K2 | readonly K2[]): Argv<Omit<{ file: unknown; }, "cleanDestination"> & InferredOptionTypes<{ cleanDestination: { boolean: true; describe: string; }; }> & { [x: string]: any; } & { ...; } & { [key in K2]: (Omit<...> & ... 2 more ... & { ...; })[K1]; }>;...' is not assignable to type '{ <K1 extends any, K2 extends string>(shortName: K1, longName: K2 | readonly K2[]): Argv<{ [x: string]: any; } & { [x: string]: any; } & { [key in K2]: ({ [x: string]: any; } & { [x: string]: any; })[K1]; }>; <K1 extends any, K2 extends string>(shortName: K2, longName: K1 | readonly K1[]): Argv<...>; (shortName: str...'.
                      Type 'Argv<Omit<{ file: unknown; }, "cleanDestination"> & InferredOptionTypes<{ cleanDestination: { boolean: true; describe: string; }; }> & { [x: string]: any; } & { [x: string]: any; } & { [x: string]: any; }>' is not assignable to type 'Argv<{ [x: string]: any; } & { [x: string]: any; } & { [x: string]: any; }>'.
                        Types of property 'command' are incompatible.
                          Type '{ <U>(command: string | readonly string[], description: string, builder?: ((args: Argv<Omit<{ file: unknown; }, "cleanDestination"> & InferredOptionTypes<{ cleanDestination: { boolean: true; describe: string; }; }> & { [x: string]: any; } & { ...; } & { ...; }>) => Argv<...>) | undefined, handler?: ((args: Arguments...' is not assignable to type '{ <U>(command: string | readonly string[], description: string, builder?: ((args: Argv<{ [x: string]: any; } & { [x: string]: any; } & { [x: string]: any; }>) => Argv<U>) | undefined, handler?: ((args: Arguments<U>) => void) | undefined): Argv<...>; <O extends { ...; }>(command: string | readonly string[], descripti...'.
                            Types of parameters 'module' and 'module' are incompatible.
                              Type 'CommandModule<{ [x: string]: any; } & { [x: string]: any; } & { [x: string]: any; }, any>' is not assignable to type 'CommandModule<Omit<{ file: unknown; }, "cleanDestination"> & InferredOptionTypes<{ cleanDestination: { boolean: true; describe: string; }; }> & { [x: string]: any; } & { [x: string]: any; } & { [x: string]: any; }, any>'.
                                Type '{ [x: string]: any; } & { [x: string]: any; } & { [x: string]: any; }' is not assignable to type 'Omit<{ file: unknown; }, "cleanDestination"> & InferredOptionTypes<{ cleanDestination: { boolean: true; describe: string; }; }> & { [x: string]: any; } & { [x: string]: any; } & { [x: string]: any; }'.
                                  Type '{ [x: string]: any; } & { [x: string]: any; } & { [x: string]: any; }' is not assignable to type 'Omit<{ file: unknown; }, "cleanDestination">'.
ERROR: 385:43  expect  TypeScript@next compile error: 
Cannot invoke an expression whose type lacks a call signature. Type 'CommandBuilder<{}, {}>' has no compatible call signatures.

stellar-base

Error in stellar-base
Error: /home/travis/build/DefinitelyTyped/DefinitelyTyped/types/stellar-base/index.d.ts:389:114
ERROR: 389:114  expect  TypeScript@next compile error: 
Type 'SetOptions<T>' does not satisfy the constraint 'Operation'.
  Type 'SetOptions<T>' is not assignable to type 'SetOptions<SignerOptions>'.
    Type 'SignerOptions' is not assignable to type 'T'.
      Type 'Ed25519PublicKey' is not assignable to type 'T'.
/home/travis/build/DefinitelyTyped/DefinitelyTyped/types/stellar-base/stellar-base-tests.ts:32:1
ERROR: 32:1     expect  Expected type to be:
  never
got:
  any
ERROR: 32:49    expect  TypeScript@next compile error: 
Property 'signer' does not exist on type 'Operation'.
  Property 'signer' does not exist on type 'AccountMerge'.
ERROR: 35:1     expect  Expected type to be:
  Ed25519PublicKey
got:
  any
ERROR: 35:51    expect  TypeScript@next compile error: 
Property 'signer' does not exist on type 'Operation'.
  Property 'signer' does not exist on type 'AccountMerge'.
ERROR: 38:1     expect  Expected type to be:
  Sha256Hash
got:
  any
ERROR: 38:51    expect  TypeScript@next compile error: 
Property 'signer' does not exist on type 'Operation'.
  Property 'signer' does not exist on type 'AccountMerge'.
ERROR: 41:1     expect  Expected type to be:
  PreAuthTx
got:
  any
ERROR: 41:51    expect  TypeScript@next compile error: 
Property 'signer' does not exist on type 'Operation'.
  Property 'signer' does not exist on type 'AccountMerge'.
    at /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/dtslint/bin/index.js:161:19
    at Generator.next (<anonymous>)
    at fulfilled (/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/dtslint/bin/index.js:5:58)
    at <anonymous>