Skip to content

Variable type incorrectly narrowed to null when a callback is passed to a function #15380

Closed
@tothdavid

Description

@tothdavid

TypeScript Version: 2.2.2
Compile with StrictNullChecks enabled.

Code

class Foo {
    public bar: string = "";
}

function test() {
    let foo: Foo | null = null;

    [1].forEach((item) => {
        foo = new Foo();
    });

    // Here Typescript compiler incorrectly thinks that 'foo' has null type 
    // although it will always be an instance of Foo class.
    if (foo) {
        // The next line does not compile because 'foo' variable has never type here.
        foo.bar;
    }
}

Expected behavior:
Should compile.
Actual behavior:
Does not compile. The compiler incorrectly narrows the type of foo variable to null type as it seems to ignore the callback given to the forEach function call, which actually will always be called.

Notes:
The code compiles without StrictNullChecks just fine.
The below code works as expected, and I believe the same would be the expected behavior for the example code as well:

class Foo {
    public bar: string = "";
}

function test() {
    let foo: Foo | null = null;

    // When calling a simple lambda explicitly this works as expected
    (() => {
        foo = new Foo();
    })();
    if (foo) {
        foo.bar;
    }
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    DuplicateAn existing issue was already created

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions