Skip to content

Commit c47b97d

Browse files
Accessor declared type was not visited
1 parent 9399b32 commit c47b97d

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

src/compiler/transformers/declarations.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -871,7 +871,7 @@ export function transformDeclarations(context: TransformationContext) {
871871
if (isConstTypeReference(asExpression.type) || (requiresUndefined && !canAddUndefined(type))) {
872872
return undefined;
873873
}
874-
else {
874+
else {
875875
return visitTypeNode(type);
876876
}
877877
}
@@ -881,7 +881,10 @@ export function transformDeclarations(context: TransformationContext) {
881881
function typeFromAccessor(node: AccessorDeclaration) {
882882
const accessorDeclarations = resolver.getAllAccessorDeclarations(node);
883883
const accessorType = getTypeAnnotationFromAllAccessorDeclarations(node, accessorDeclarations);
884-
return accessorType ?? inferAccessorType(accessorDeclarations.getAccessor ?? node);
884+
if(accessorType) {
885+
return visitTypeNode(accessorType);
886+
}
887+
return inferAccessorType(accessorDeclarations.getAccessor ?? node);
885888
}
886889
function typeFromVariable(node: VariableDeclaration) {
887890
const declaredType = node.type;
Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
accessorDeclarationEmitVisibilityErrors.ts(2,18): error TS2304: Cannot find name 'DoesNotExist'.
2+
accessorDeclarationEmitVisibilityErrors.ts(2,18): error TS4106: Parameter 'arg' of accessor has or is using private name 'DoesNotExist'.
23

34

4-
==== accessorDeclarationEmitVisibilityErrors.ts (1 errors) ====
5+
==== accessorDeclarationEmitVisibilityErrors.ts (2 errors) ====
56
export class Q {
67
set bet(arg: DoesNotExist) {}
78
~~~~~~~~~~~~
89
!!! error TS2304: Cannot find name 'DoesNotExist'.
10+
~~~~~~~~~~~~
11+
!!! error TS4106: Parameter 'arg' of accessor has or is using private name 'DoesNotExist'.
912
}

tests/baselines/reference/accessorDeclarationEmitVisibilityErrors.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,3 @@ export class Q {
99
export class Q {
1010
set bet(arg) { }
1111
}
12-
13-
14-
//// [accessorDeclarationEmitVisibilityErrors.d.ts]
15-
export declare class Q {
16-
set bet(arg: DoesNotExist);
17-
}

0 commit comments

Comments
 (0)