Create ancestor projects for composite projects till projectRoot but load them and their references when doing all project wide operation like rename

Author: sheetalkamat

src/server/editorServices.ts

@@ -2533,6 +2533,28 @@ namespace ts.server {
             }
         }
 
+        /*@internal*/
+        loadAncestorAndReferenceConfiguredProjects(forProjects: ReadonlyMap<Project>) {
+            // Load all the projects ancestor projects for seen projects
+            this.configuredProjects.forEach(project => {
+                if (project.isInitialLoadPending() &&
+                    project.forEachProjectReference(returnFalse, returnFalse, path => forProjects.has(path))) {
+                    // Load the project
+                    project.updateGraph();
+                    // We want to also load the referenced projects
+                    // TODO:: Save them when project stays alive but at lower priority
+                    project.forEachProjectReference(ref => {
+                        if (ref) {
+                            const configFileName = toNormalizedPath(ref.sourceFile.fileName);
+                            const configuredProject = this.findConfiguredProjectByProjectName(configFileName) ||
+                                this.createAndLoadConfiguredProject(toNormalizedPath(configFileName), `Creating project for transitive reference of ancestor project: ${project.projectName}`);
+                            updateProjectIfDirty(configuredProject);
+                        }
+                    }, noop, noop);
+                }
+            });
+        }
+
         private removeOrphanConfiguredProjects() {
             const toRemoveConfiguredProjects = cloneMap(this.configuredProjects);
 
@@ -2546,7 +2568,7 @@ namespace ts.server {
                     markOriginalProjectsAsUsed(project);
                 }
                 else {
-                    project.forEachResolvedProjectReference(
+                    project.forEachProjectReference(
                         resolvedRef => markProjectAsUsedIfReferencedConfigWithOpenRef(project, resolvedRef && this.configuredProjects.get(resolvedRef.sourceFile.path)),
                         projectRef => markProjectAsUsedIfReferencedConfigWithOpenRef(project, this.configuredProjects.get(this.toPath(projectRef.path))),
                         potentialProjectRef => markProjectAsUsedIfReferencedConfigWithOpenRef(project, this.configuredProjects.get(potentialProjectRef))

src/server/project.ts

@@ -1443,7 +1443,7 @@ namespace ts.server {
         }
 
         /*@internal*/
-        forEachResolvedProjectReference<T>(
+        forEachProjectReference<T>(
             cb: (resolvedProjectReference: ResolvedProjectReference | undefined, resolvedProjectReferencePath: Path) => T | undefined,
             cbProjectRef: (projectReference: ProjectReference) => T | undefined,
             cbPotentialProjectRef: (path: Path) => T | undefined

src/server/session.ts

@@ -412,7 +412,7 @@ namespace ts.server {
     ): void {
         const projectService = defaultProject.projectService;
         let toDo: ProjectAndLocation<TLocation>[] | undefined;
-        const seenProjects = createMap<true>();
+        const seenProjects = createMap<Project>();
         forEachProjectInProjects(projects, initialLocation && initialLocation.fileName, (project, path) => {
             // TLocation shoud be either `sourcemaps.SourceMappableLocation` or `undefined`. Since `initialLocation` is `TLocation` this cast should be valid.
             const location = (initialLocation ? { fileName: path, position: initialLocation.position } : undefined) as TLocation;
@@ -421,9 +421,11 @@ namespace ts.server {
 
         // After initial references are collected, go over every other project and see if it has a reference for the symbol definition.
         if (getDefinition) {
+            projectService.loadAncestorAndReferenceConfiguredProjects(seenProjects);
+
             const memGetDefinition = memoize(getDefinition);
             projectService.forEachEnabledProject(project => {
-                if (!addToSeen(seenProjects, project.projectName)) return;
+                if (!addToSeen(seenProjects, project)) return;
                 const definition = getDefinitionInProject(memGetDefinition(), defaultProject, project);
                 if (definition) {
                     toDo = callbackProjectAndLocation<TLocation>({ project, location: definition as TLocation }, projectService, toDo, seenProjects, cb);
@@ -442,16 +444,24 @@ namespace ts.server {
         return mappedDefinition && project.containsFile(toNormalizedPath(mappedDefinition.fileName)) ? mappedDefinition : undefined;
     }
 
+    function addToSeen(seenProjects: Map<Project>, project: Project) {
+        return ts.addToSeen(seenProjects, getProjectKey(project), project);
+    }
+
+    function getProjectKey(project: Project) {
+        return project.projectKind === ProjectKind.Configured ? (project as ConfiguredProject).canonicalConfigFilePath : project.projectName;
+    }
+
     function callbackProjectAndLocation<TLocation extends sourcemaps.SourceMappableLocation | undefined>(
         projectAndLocation: ProjectAndLocation<TLocation>,
         projectService: ProjectService,
         toDo: ProjectAndLocation<TLocation>[] | undefined,
-        seenProjects: Map<true>,
+        seenProjects: Map<Project>,
         cb: CombineProjectOutputCallback<TLocation>,
     ): ProjectAndLocation<TLocation>[] | undefined {
         if (projectAndLocation.project.getCancellationToken().isCancellationRequested()) return undefined; // Skip rest of toDo if cancelled
         cb(projectAndLocation, (project, location) => {
-            seenProjects.set(projectAndLocation.project.projectName, true);
+            seenProjects.set(getProjectKey(projectAndLocation.project), projectAndLocation.project);
             const originalLocation = projectService.getOriginalLocationEnsuringConfiguredProject(project, location);
             if (!originalLocation) return undefined;
 
@@ -472,8 +482,8 @@ namespace ts.server {
         return toDo;
     }
 
-    function addToTodo<TLocation extends sourcemaps.SourceMappableLocation | undefined>(projectAndLocation: ProjectAndLocation<TLocation>, toDo: Push<ProjectAndLocation<TLocation>>, seenProjects: Map<true>): void {
-        if (addToSeen(seenProjects, projectAndLocation.project.projectName)) toDo.push(projectAndLocation);
+    function addToTodo<TLocation extends sourcemaps.SourceMappableLocation | undefined>(projectAndLocation: ProjectAndLocation<TLocation>, toDo: Push<ProjectAndLocation<TLocation>>, seenProjects: Map<Project>): void {
+        if (addToSeen(seenProjects, projectAndLocation.project)) toDo.push(projectAndLocation);
     }
 
     function documentSpanLocation({ fileName, textSpan }: DocumentSpan): sourcemaps.SourceMappableLocation {