Fix crash on addImportFromExportedSymbol with default exported symbol (#52694)

Author: gabritto

src/services/utilities.ts

@@ -3959,8 +3959,12 @@ function needsNameFromDeclaration(symbol: Symbol) {
     return !(symbol.flags & SymbolFlags.Transient) && (symbol.escapedName === InternalSymbolName.ExportEquals || symbol.escapedName === InternalSymbolName.Default);
 }
 
-function getDefaultLikeExportNameFromDeclaration(symbol: Symbol) {
-    return firstDefined(symbol.declarations, d => isExportAssignment(d) ? tryCast(skipOuterExpressions(d.expression), isIdentifier)?.text : undefined);
+function getDefaultLikeExportNameFromDeclaration(symbol: Symbol): string | undefined {
+    return firstDefined(symbol.declarations, d =>
+        isExportAssignment(d)
+            ? tryCast(skipOuterExpressions(d.expression), isIdentifier)?.text
+            : tryCast(getNameOfDeclaration(d), isIdentifier)?.text
+    );
 }
 
 function getSymbolParentOrFail(symbol: Symbol) {

tests/cases/fourslash/completionsOverridingMethodDefaultExported.ts

@@ -0,0 +1,38 @@
+/// <reference path="fourslash.ts" />
+
+// Issue #52662
+
+// @filename: other.ts
+//// export default class Other {}
+
+// @filename: base.ts
+//// import Other from "./other";
+//// export class Base {
+////     foo(): Other {
+////         throw new Error("");
+////     }
+//// }
+
+// @filename: derived.ts
+//// import { Base } from "./base";
+//// export class Derived extends Base {
+////     /**/
+//// }
+
+verify.completions({
+    marker: "",
+    isNewIdentifierLocation: true,
+    preferences: {
+        includeCompletionsWithInsertText: true,
+        includeCompletionsWithClassMemberSnippets: true,
+    },
+    includes: [
+        {
+            name: "foo",
+            sortText: completion.SortText.ClassMemberSnippets,
+            insertText: "foo(): Other {\n}",
+            hasAction: true,
+            source: completion.CompletionSource.ClassMemberSnippet,
+        }
+    ],
+})