Merge pull request #28419 from Microsoft/elaborateAssert

sheetalkamat · web-flow · commit 62419bb10390 · 2018-11-08T15:45:38.000-08:00
Elaborate assert of infos attached to project
diff --git a/src/server/editorServices.ts b/src/server/editorServices.ts
@@ -1042,7 +1042,7 @@ namespace ts.server {
 
             project.close();
             if (Debug.shouldAssert(AssertionLevel.Normal)) {
-                this.filenameToScriptInfo.forEach(info => Debug.assert(!info.isAttached(project)));
+                this.filenameToScriptInfo.forEach(info => Debug.assert(!info.isAttached(project), "Found script Info still attached to project", () => `${project.projectName}: ScriptInfos still attached: ${JSON.stringify(mapDefined(arrayFrom(this.filenameToScriptInfo.values()), info => info.isAttached(project) ? info : undefined))}`));
             }
             // Remove the project from pending project updates
             this.pendingProjectUpdates.delete(project.getProjectName());

Original file line number	Diff line number	Diff line change
`@@ -1042,7 +1042,7 @@ namespace ts.server {`
`1042`	`1042`
`1043`	`1043`	`project.close();`
`1044`	`1044`	`if (Debug.shouldAssert(AssertionLevel.Normal)) {`
`1045`		`- this.filenameToScriptInfo.forEach(info => Debug.assert(!info.isAttached(project)));`
	`1045`	+ this.filenameToScriptInfo.forEach(info => Debug.assert(!info.isAttached(project), "Found script Info still attached to project", () => `${project.projectName}: ScriptInfos still attached: ${JSON.stringify(mapDefined(arrayFrom(this.filenameToScriptInfo.values()), info => info.isAttached(project) ? info : undefined))}`));
`1046`	`1046`	`}`
`1047`	`1047`	`// Remove the project from pending project updates`
`1048`	`1048`	`this.pendingProjectUpdates.delete(project.getProjectName());`