Skip to content

Commit 550d912

Browse files
committed
Refactor code to make if statements cheaper
1 parent 3354436 commit 550d912

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

src/server/editorServices.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -475,10 +475,7 @@ namespace ts.server {
475475

476476
isRoot(info: ScriptInfo) {
477477
if (this.languageServiceDiabled) {
478-
if (!this.projectOptions) {
479-
return undefined;
480-
}
481-
return forEach(this.projectOptions.files, file => toPath(file, file, createGetCanonicalFileName(this.projectService.host.useCaseSensitiveFileNames)) === info.path);
478+
return undefined;
482479
}
483480

484481
return this.compilerService.host.roots.some(root => root === info);
@@ -1421,7 +1418,7 @@ namespace ts.server {
14211418
return errors;
14221419
}
14231420
else {
1424-
if (this.exceedTotalNonTsFileSizeLimit(projectOptions.files) && projectOptions.compilerOptions && !projectOptions.compilerOptions.disableSizeLimit) {
1421+
if (projectOptions.compilerOptions && !projectOptions.compilerOptions.disableSizeLimit && this.exceedTotalNonTsFileSizeLimit(projectOptions.files)) {
14251422
project.setProjectOptions(projectOptions);
14261423
if (project.languageServiceDiabled) {
14271424
return;

src/server/session.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,7 @@ namespace ts.server {
443443
const info = this.projectService.getScriptInfo(file);
444444
const projects = this.projectService.findReferencingProjects(info);
445445
const projectsWithLanguageServiceEnabeld = ts.filter(projects, p => !p.languageServiceDiabled);
446-
if (projects.length === 0 || projectsWithLanguageServiceEnabeld.length === 0) {
446+
if (projectsWithLanguageServiceEnabeld.length === 0) {
447447
throw Errors.NoProject;
448448
}
449449

@@ -526,7 +526,7 @@ namespace ts.server {
526526
const info = this.projectService.getScriptInfo(file);
527527
const projects = this.projectService.findReferencingProjects(info);
528528
const projectsWithLanguageServiceEnabeld = ts.filter(projects, p => !p.languageServiceDiabled);
529-
if (projects.length === 0 || projectsWithLanguageServiceEnabeld.length === 0) {
529+
if (projectsWithLanguageServiceEnabeld.length === 0) {
530530
throw Errors.NoProject;
531531
}
532532

@@ -904,7 +904,7 @@ namespace ts.server {
904904
const info = this.projectService.getScriptInfo(file);
905905
const projects = this.projectService.findReferencingProjects(info);
906906
const projectsWithLanguageServiceEnabeld = ts.filter(projects, p => !p.languageServiceDiabled);
907-
if (projects.length === 0 || projectsWithLanguageServiceEnabeld.length === 0) {
907+
if (projectsWithLanguageServiceEnabeld.length === 0) {
908908
throw Errors.NoProject;
909909
}
910910

0 commit comments

Comments
 (0)