Remove notes

Author: andrewbranch

tests/baselines/reference/checkOrderDependenceGenericAssignability.errors.txt

@@ -1,33 +1,11 @@
-tests/cases/compiler/checkOrderDependenceGenericAssignability.ts(46,7): error TS2322: Type 'Parent<unknown>' is not assignable to type 'Parent<string>'.
+tests/cases/compiler/checkOrderDependenceGenericAssignability.ts(24,7): error TS2322: Type 'Parent<unknown>' is not assignable to type 'Parent<string>'.
   Types of property 'child' are incompatible.
     Type 'Child<unknown, unknown>' is not assignable to type 'Child<string, unknown>'.
       Type 'unknown' is not assignable to type 'string'.
 
 
 ==== tests/cases/compiler/checkOrderDependenceGenericAssignability.ts (1 errors) ====
-    /*
-    
-    Debugging notes: variance measurement for `Parent` is getting set to
-    `VarianceFlags.Independent`, implying that its type parameter is never
-    witnessed at all. It arrived at this conclusion by checking the assignability
-    of `Parent` instantiated with marker types. It first checks assignability in
-    both directions with instantiations with super/sub-related marker types, and
-    assignability appears to return true in both directions; however, it actually
-    is returning `Ternary.Unknown`, due to being unable to answer questions about
-    the assignability of the types' `parent` and `child` properties without knowing
-    their variances. After (incorrectly) concluding that `Parent` is bivariant on `A`,
-    it checks another set of instantiations with markers that are unrelated to each
-    other. That too comes back as `Ternary.Unknown` but is interpreted as true, so
-    the variance gets updated to `Independent`, since instantiating `Parent` with
-    all kinds of different markers with different assignability to each other
-    apparently had no effect on the instantiations' assignability to each other.
-    
-    I'm not sure if any of those comparisons ever actually looked at `a` and `b`,
-    which should provide some non-recursive concrete variance information. I'm also
-    not sure if `outofbandVarianceMarkerHandler` should have been called at some point,
-    but it was not.
-    
-    */
+    // #44572
 
     interface Parent<A> {
       child: Child<A> | null;

tests/baselines/reference/checkOrderDependenceGenericAssignability.js

@@ -1,27 +1,5 @@
 //// [checkOrderDependenceGenericAssignability.ts]
-/*
-
-Debugging notes: variance measurement for `Parent` is getting set to
-`VarianceFlags.Independent`, implying that its type parameter is never
-witnessed at all. It arrived at this conclusion by checking the assignability
-of `Parent` instantiated with marker types. It first checks assignability in
-both directions with instantiations with super/sub-related marker types, and
-assignability appears to return true in both directions; however, it actually
-is returning `Ternary.Unknown`, due to being unable to answer questions about
-the assignability of the types' `parent` and `child` properties without knowing
-their variances. After (incorrectly) concluding that `Parent` is bivariant on `A`,
-it checks another set of instantiations with markers that are unrelated to each
-other. That too comes back as `Ternary.Unknown` but is interpreted as true, so
-the variance gets updated to `Independent`, since instantiating `Parent` with
-all kinds of different markers with different assignability to each other
-apparently had no effect on the instantiations' assignability to each other.
-
-I'm not sure if any of those comparisons ever actually looked at `a` and `b`,
-which should provide some non-recursive concrete variance information. I'm also
-not sure if `outofbandVarianceMarkerHandler` should have been called at some point,
-but it was not.
-
-*/
+// #44572
 
 interface Parent<A> {
   child: Child<A> | null;
@@ -48,29 +26,7 @@ const notString: Parent<string> = pu;
 
 
 //// [checkOrderDependenceGenericAssignability.js]
-/*
-
-Debugging notes: variance measurement for `Parent` is getting set to
-`VarianceFlags.Independent`, implying that its type parameter is never
-witnessed at all. It arrived at this conclusion by checking the assignability
-of `Parent` instantiated with marker types. It first checks assignability in
-both directions with instantiations with super/sub-related marker types, and
-assignability appears to return true in both directions; however, it actually
-is returning `Ternary.Unknown`, due to being unable to answer questions about
-the assignability of the types' `parent` and `child` properties without knowing
-their variances. After (incorrectly) concluding that `Parent` is bivariant on `A`,
-it checks another set of instantiations with markers that are unrelated to each
-other. That too comes back as `Ternary.Unknown` but is interpreted as true, so
-the variance gets updated to `Independent`, since instantiating `Parent` with
-all kinds of different markers with different assignability to each other
-apparently had no effect on the instantiations' assignability to each other.
-
-I'm not sure if any of those comparisons ever actually looked at `a` and `b`,
-which should provide some non-recursive concrete variance information. I'm also
-not sure if `outofbandVarianceMarkerHandler` should have been called at some point,
-but it was not.
-
-*/
+// #44572
 function fn(inp) {
     // This assignability check defeats the later one
     var a = inp;

tests/baselines/reference/checkOrderDependenceGenericAssignability.symbols

@@ -1,89 +1,67 @@
 === tests/cases/compiler/checkOrderDependenceGenericAssignability.ts ===
-/*
-
-Debugging notes: variance measurement for `Parent` is getting set to
-`VarianceFlags.Independent`, implying that its type parameter is never
-witnessed at all. It arrived at this conclusion by checking the assignability
-of `Parent` instantiated with marker types. It first checks assignability in
-both directions with instantiations with super/sub-related marker types, and
-assignability appears to return true in both directions; however, it actually
-is returning `Ternary.Unknown`, due to being unable to answer questions about
-the assignability of the types' `parent` and `child` properties without knowing
-their variances. After (incorrectly) concluding that `Parent` is bivariant on `A`,
-it checks another set of instantiations with markers that are unrelated to each
-other. That too comes back as `Ternary.Unknown` but is interpreted as true, so
-the variance gets updated to `Independent`, since instantiating `Parent` with
-all kinds of different markers with different assignability to each other
-apparently had no effect on the instantiations' assignability to each other.
-
-I'm not sure if any of those comparisons ever actually looked at `a` and `b`,
-which should provide some non-recursive concrete variance information. I'm also
-not sure if `outofbandVarianceMarkerHandler` should have been called at some point,
-but it was not.
-
-*/
+// #44572
 
 interface Parent<A> {
 >Parent : Symbol(Parent, Decl(checkOrderDependenceGenericAssignability.ts, 0, 0))
->A : Symbol(A, Decl(checkOrderDependenceGenericAssignability.ts, 24, 17))
+>A : Symbol(A, Decl(checkOrderDependenceGenericAssignability.ts, 2, 17))
 
   child: Child<A> | null;
->child : Symbol(Parent.child, Decl(checkOrderDependenceGenericAssignability.ts, 24, 21))
->Child : Symbol(Child, Decl(checkOrderDependenceGenericAssignability.ts, 27, 1))
->A : Symbol(A, Decl(checkOrderDependenceGenericAssignability.ts, 24, 17))
+>child : Symbol(Parent.child, Decl(checkOrderDependenceGenericAssignability.ts, 2, 21))
+>Child : Symbol(Child, Decl(checkOrderDependenceGenericAssignability.ts, 5, 1))
+>A : Symbol(A, Decl(checkOrderDependenceGenericAssignability.ts, 2, 17))
 
   parent: Parent<A> | null;
->parent : Symbol(Parent.parent, Decl(checkOrderDependenceGenericAssignability.ts, 25, 25))
+>parent : Symbol(Parent.parent, Decl(checkOrderDependenceGenericAssignability.ts, 3, 25))
 >Parent : Symbol(Parent, Decl(checkOrderDependenceGenericAssignability.ts, 0, 0))
->A : Symbol(A, Decl(checkOrderDependenceGenericAssignability.ts, 24, 17))
+>A : Symbol(A, Decl(checkOrderDependenceGenericAssignability.ts, 2, 17))
 }
 
 interface Child<A, B = unknown> extends Parent<A> {
->Child : Symbol(Child, Decl(checkOrderDependenceGenericAssignability.ts, 27, 1))
->A : Symbol(A, Decl(checkOrderDependenceGenericAssignability.ts, 29, 16))
->B : Symbol(B, Decl(checkOrderDependenceGenericAssignability.ts, 29, 18))
+>Child : Symbol(Child, Decl(checkOrderDependenceGenericAssignability.ts, 5, 1))
+>A : Symbol(A, Decl(checkOrderDependenceGenericAssignability.ts, 7, 16))
+>B : Symbol(B, Decl(checkOrderDependenceGenericAssignability.ts, 7, 18))
 >Parent : Symbol(Parent, Decl(checkOrderDependenceGenericAssignability.ts, 0, 0))
->A : Symbol(A, Decl(checkOrderDependenceGenericAssignability.ts, 29, 16))
+>A : Symbol(A, Decl(checkOrderDependenceGenericAssignability.ts, 7, 16))
 
   readonly a: A;
->a : Symbol(Child.a, Decl(checkOrderDependenceGenericAssignability.ts, 29, 51))
->A : Symbol(A, Decl(checkOrderDependenceGenericAssignability.ts, 29, 16))
+>a : Symbol(Child.a, Decl(checkOrderDependenceGenericAssignability.ts, 7, 51))
+>A : Symbol(A, Decl(checkOrderDependenceGenericAssignability.ts, 7, 16))
 
   // This field isn't necessary to the repro, but the
   // type parameter is, so including it
   readonly b: B;
->b : Symbol(Child.b, Decl(checkOrderDependenceGenericAssignability.ts, 30, 16))
->B : Symbol(B, Decl(checkOrderDependenceGenericAssignability.ts, 29, 18))
+>b : Symbol(Child.b, Decl(checkOrderDependenceGenericAssignability.ts, 8, 16))
+>B : Symbol(B, Decl(checkOrderDependenceGenericAssignability.ts, 7, 18))
 }
 
 function fn<A>(inp: Child<A>) {
->fn : Symbol(fn, Decl(checkOrderDependenceGenericAssignability.ts, 34, 1))
->A : Symbol(A, Decl(checkOrderDependenceGenericAssignability.ts, 36, 12))
->inp : Symbol(inp, Decl(checkOrderDependenceGenericAssignability.ts, 36, 15))
->Child : Symbol(Child, Decl(checkOrderDependenceGenericAssignability.ts, 27, 1))
->A : Symbol(A, Decl(checkOrderDependenceGenericAssignability.ts, 36, 12))
+>fn : Symbol(fn, Decl(checkOrderDependenceGenericAssignability.ts, 12, 1))
+>A : Symbol(A, Decl(checkOrderDependenceGenericAssignability.ts, 14, 12))
+>inp : Symbol(inp, Decl(checkOrderDependenceGenericAssignability.ts, 14, 15))
+>Child : Symbol(Child, Decl(checkOrderDependenceGenericAssignability.ts, 5, 1))
+>A : Symbol(A, Decl(checkOrderDependenceGenericAssignability.ts, 14, 12))
 
   // This assignability check defeats the later one
   const a: Child<unknown> = inp;
->a : Symbol(a, Decl(checkOrderDependenceGenericAssignability.ts, 38, 7))
->Child : Symbol(Child, Decl(checkOrderDependenceGenericAssignability.ts, 27, 1))
->inp : Symbol(inp, Decl(checkOrderDependenceGenericAssignability.ts, 36, 15))
+>a : Symbol(a, Decl(checkOrderDependenceGenericAssignability.ts, 16, 7))
+>Child : Symbol(Child, Decl(checkOrderDependenceGenericAssignability.ts, 5, 1))
+>inp : Symbol(inp, Decl(checkOrderDependenceGenericAssignability.ts, 14, 15))
 }
 
 // Allowed initialization of pu
 const pu: Parent<unknown> = { child: { a: 0, b: 0, child: null, parent: null }, parent: null };
->pu : Symbol(pu, Decl(checkOrderDependenceGenericAssignability.ts, 42, 5))
+>pu : Symbol(pu, Decl(checkOrderDependenceGenericAssignability.ts, 20, 5))
 >Parent : Symbol(Parent, Decl(checkOrderDependenceGenericAssignability.ts, 0, 0))
->child : Symbol(child, Decl(checkOrderDependenceGenericAssignability.ts, 42, 29))
->a : Symbol(a, Decl(checkOrderDependenceGenericAssignability.ts, 42, 38))
->b : Symbol(b, Decl(checkOrderDependenceGenericAssignability.ts, 42, 44))
->child : Symbol(child, Decl(checkOrderDependenceGenericAssignability.ts, 42, 50))
->parent : Symbol(parent, Decl(checkOrderDependenceGenericAssignability.ts, 42, 63))
->parent : Symbol(parent, Decl(checkOrderDependenceGenericAssignability.ts, 42, 79))
+>child : Symbol(child, Decl(checkOrderDependenceGenericAssignability.ts, 20, 29))
+>a : Symbol(a, Decl(checkOrderDependenceGenericAssignability.ts, 20, 38))
+>b : Symbol(b, Decl(checkOrderDependenceGenericAssignability.ts, 20, 44))
+>child : Symbol(child, Decl(checkOrderDependenceGenericAssignability.ts, 20, 50))
+>parent : Symbol(parent, Decl(checkOrderDependenceGenericAssignability.ts, 20, 63))
+>parent : Symbol(parent, Decl(checkOrderDependenceGenericAssignability.ts, 20, 79))
 
 // Should error
 const notString: Parent<string> = pu;
->notString : Symbol(notString, Decl(checkOrderDependenceGenericAssignability.ts, 45, 5))
+>notString : Symbol(notString, Decl(checkOrderDependenceGenericAssignability.ts, 23, 5))
 >Parent : Symbol(Parent, Decl(checkOrderDependenceGenericAssignability.ts, 0, 0))
->pu : Symbol(pu, Decl(checkOrderDependenceGenericAssignability.ts, 42, 5))
+>pu : Symbol(pu, Decl(checkOrderDependenceGenericAssignability.ts, 20, 5))
 

tests/baselines/reference/checkOrderDependenceGenericAssignability.types

@@ -1,27 +1,5 @@
 === tests/cases/compiler/checkOrderDependenceGenericAssignability.ts ===
-/*
-
-Debugging notes: variance measurement for `Parent` is getting set to
-`VarianceFlags.Independent`, implying that its type parameter is never
-witnessed at all. It arrived at this conclusion by checking the assignability
-of `Parent` instantiated with marker types. It first checks assignability in
-both directions with instantiations with super/sub-related marker types, and
-assignability appears to return true in both directions; however, it actually
-is returning `Ternary.Unknown`, due to being unable to answer questions about
-the assignability of the types' `parent` and `child` properties without knowing
-their variances. After (incorrectly) concluding that `Parent` is bivariant on `A`,
-it checks another set of instantiations with markers that are unrelated to each
-other. That too comes back as `Ternary.Unknown` but is interpreted as true, so
-the variance gets updated to `Independent`, since instantiating `Parent` with
-all kinds of different markers with different assignability to each other
-apparently had no effect on the instantiations' assignability to each other.
-
-I'm not sure if any of those comparisons ever actually looked at `a` and `b`,
-which should provide some non-recursive concrete variance information. I'm also
-not sure if `outofbandVarianceMarkerHandler` should have been called at some point,
-but it was not.
-
-*/
+// #44572
 
 interface Parent<A> {
   child: Child<A> | null;

tests/cases/compiler/checkOrderDependenceGenericAssignability.ts

@@ -1,26 +1,4 @@
-/*
-
-Debugging notes: variance measurement for `Parent` is getting set to
-`VarianceFlags.Independent`, implying that its type parameter is never
-witnessed at all. It arrived at this conclusion by checking the assignability
-of `Parent` instantiated with marker types. It first checks assignability in
-both directions with instantiations with super/sub-related marker types, and
-assignability appears to return true in both directions; however, it actually
-is returning `Ternary.Unknown`, due to being unable to answer questions about
-the assignability of the types' `parent` and `child` properties without knowing
-their variances. After (incorrectly) concluding that `Parent` is bivariant on `A`,
-it checks another set of instantiations with markers that are unrelated to each
-other. That too comes back as `Ternary.Unknown` but is interpreted as true, so
-the variance gets updated to `Independent`, since instantiating `Parent` with
-all kinds of different markers with different assignability to each other
-apparently had no effect on the instantiations' assignability to each other.
-
-I'm not sure if any of those comparisons ever actually looked at `a` and `b`,
-which should provide some non-recursive concrete variance information. I'm also
-not sure if `outofbandVarianceMarkerHandler` should have been called at some point,
-but it was not.
-
-*/
+// #44572
 
 interface Parent<A> {
   child: Child<A> | null;