Merge pull request #16433 from Microsoft/suppressBraceCompletionOfQuotesinComments

Suppress brace completion of Quotes in Comments

Author: aozgaa

src/services/services.ts

@@ -1822,6 +1822,13 @@ namespace ts {
                 return false;
             }
 
+            switch (openingBrace) {
+                case CharacterCodes.singleQuote:
+                case CharacterCodes.doubleQuote:
+                case CharacterCodes.backtick:
+                    return !isInComment(sourceFile, position);
+            }
+
             return true;
         }
 

tests/cases/fourslash/commentBraceCompletionPosition.ts

@@ -7,17 +7,30 @@
 ////     // inside regular comment /*2*/
 ////     var c = "";
 ////
-////    /* inside multi-
-////       line comment /*3*/ 
+////    /*3*//* inside /*4*/multi-
+////       line comment /*5*/ 
 ////    */
 ////    var y =12;
 //// }
 
 goTo.marker('1');
 verify.isValidBraceCompletionAtPosition('(');
+verify.not.isValidBraceCompletionAtPosition('"');
+verify.not.isValidBraceCompletionAtPosition(`'`);
+verify.not.isValidBraceCompletionAtPosition('`');
 
 goTo.marker('2');
 verify.isValidBraceCompletionAtPosition('(');
+verify.not.isValidBraceCompletionAtPosition('"');
 
 goTo.marker('3');
-verify.isValidBraceCompletionAtPosition('(');
+verify.isValidBraceCompletionAtPosition('(');
+verify.isValidBraceCompletionAtPosition('"');
+
+goTo.marker('4');
+verify.isValidBraceCompletionAtPosition('(');
+verify.not.isValidBraceCompletionAtPosition('"');
+
+goTo.marker('5');
+verify.isValidBraceCompletionAtPosition('(');
+verify.not.isValidBraceCompletionAtPosition('"');