Cancels the isExternalLibraryImport changes - side effects on emits

Author: arcanis

src/compiler/moduleNameResolver.ts

@@ -1005,19 +1005,13 @@ namespace ts {
                 }
 
                 let resolvedValue = resolved.value;
-
-                const isExternalLibraryImport = resolvedValue && isPnpAvailable()
-                    ? checkPnpExternalLibraryImport(resolvedValue)
-                    : true;
-
-                // For node_modules lookups, get the real path so that multiple accesses to an `npm link`-ed module do not create duplicate files.
                 if (!compilerOptions.preserveSymlinks && resolvedValue && !resolvedValue.originalPath) {
                     const path = realPath(resolvedValue.path, host, traceEnabled);
                     const originalPath = path === resolvedValue.path ? undefined : resolvedValue.path;
                     resolvedValue = { ...resolvedValue, path, originalPath };
                 }
-
-                return { value: resolvedValue && { resolved: resolvedValue, isExternalLibraryImport } };
+                // For node_modules lookups, get the real path so that multiple accesses to an `npm link`-ed module do not create duplicate files.
+                return { value: resolvedValue && { resolved: resolvedValue, isExternalLibraryImport: true } };
             }
             else {
                 const { path: candidate, parts } = normalizePathAndParts(combinePaths(containingDirectory, moduleName));
@@ -1596,13 +1590,7 @@ namespace ts {
     }
 
     function getPnpApi() {
-        return require("pnpapi") as {
-            findPackageLocator: (path: string) => ({name: string, reference: string}) | null,
-            resolveToUnqualified: (request: string, issuer: string, opts: {considerBuiltins: boolean}) => string,
-            getLocator: (name: string, reference: string) => ({name: string, reference: string}),
-            getPackageInformation: (locator: {name: string, reference: string}) => any,
-            getDependencyTreeRoots: () => any[],
-        };
+        return require("pnpapi");
     }
 
     function loadPnpPackageResolution(packageName: string, containingDirectory: string) {
@@ -1643,22 +1631,8 @@ namespace ts {
             }
         }
 
-        return toSearchResult(resolved);
-    }
-
-    function checkPnpExternalLibraryImport(resolvedValue: Resolved) {
-        const pnpApi = getPnpApi();
-
-        const ownerPackage = pnpApi.findPackageLocator(resolvedValue.path);
-        if (!ownerPackage) {
-            return true;
+        if (resolved) {
+            return toSearchResult(resolved);
         }
-
-        const rootLocators = pnpApi.getDependencyTreeRoots();
-
-        // External if none of the root locators owns the file
-        return !rootLocators.some(root => {
-            return root.name === ownerPackage.name && root.reference === ownerPackage.reference;
-        });
     }
 }