Can we have token for explicitly UPPER_CASED variable?

[rokoroku]

TS and JS Grammar Extension version: 0.0.43 / latest

Code

// Please include a code snippet that demonstrates the issue
const UPPER_CASED_CONSTANTS_VARIABLE = 1;
const lower_cased_variable = 2;

#542
858d33f

Prior to above fix, we can have UPPER_CASED variable as a constant so we can apply style for the uppercased constant differently, however, it's impossible now

Is it possible to have uppercased constant variable as another token? (e.g. variables.uppercased.constants, variable.uppercased.readwrite, ...)

[sheetalkamat]

Upper cased variables are still constants:

For: const UPPER_CASED_CONSTANTS_VARIABLE = 1;
Scope:                         source.ts
                               meta.var.expr.ts
                               meta.var-single-variable.expr.ts
                               meta.definition.variable.ts
                               variable.other.constant.ts

For: var UPPER_CASED_CONSTANTS_VARIABLE = 1;
Scope:                         source.ts
                               meta.var.expr.ts
                               meta.var-single-variable.expr.ts
                               meta.definition.variable.ts
                               variable.other.constant.ts

[rokoroku]

@sheetalkamat

I meant, I want to distinguish between UPPER_CASED and other-cased variables.

[fdln]

@rokoroku
Agree, it will good to see syntax highlighting like this:

[uncenter]

Fwiw both Helix and Neovim only capture screaming snake-cased constants as @constant (equivalent of variable.other.constant), not just any variable declared with the const keyword. We could do this approach, or at least add some additional token indicating the capitalization user convention of constants - for theming purposes.

https://github.com/nvim-treesitter/nvim-treesitter/blob/42fc28ba918343ebfd5565147a42a26580579482/queries/ecma/highlights.scm#L27-L28

https://github.com/helix-editor/helix/blob/b6ccbddc77bc2e2c2d02cfd5444594e3cc46c938/runtime/queries/ecma/highlights.scm#L249-L254