Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log_graph is pretty restrictive #78

Open
shatu opened this issue Dec 23, 2021 · 0 comments
Open

log_graph is pretty restrictive #78

shatu opened this issue Dec 23, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@shatu
Copy link
Collaborator

shatu commented Dec 23, 2021

Currently, the log_graph function in the tensorboard writer only supports the tuple type for the sample input. It should at least be extended to support a dictionary input as well, which is fairly common with HF style inputs.

PyMarlin/pymarlin/utils/writer/tensorboard.py

Line 102 in fb8bbc9

if isinstance(inputs, tuple):

@shatu shatu added the enhancement New feature or request label Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shatu