Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user defined save_best_checkpoint() hook #58

Open
jsleep opened this issue Aug 18, 2021 · 1 comment
Open

user defined save_best_checkpoint() hook #58

jsleep opened this issue Aug 18, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@jsleep
Copy link
Contributor

jsleep commented Aug 18, 2021

it should be a feature of our library to keep the "best" checkpoint based on a tracked metric like the minimum value of validation loss.

this could be a semi-big change because:

  • we do not have any metric tracking
  • we do not have any conditional checkpointing implemented, but Eduardo make checkpointing pretty generic for it.
@jsleep jsleep added the enhancement New feature or request label Aug 18, 2021
@ananthrs1
Copy link
Contributor

We can have the current checkpointing logic as is to check point every specific interval
We can enhance the trainer code to take a custom function callback from the scenario code that dictates which is the best checkpoint to use based on operations on the custom metric relevant to that scenario. Then the trainer can overwrite the best checkpoint based on scenario owner implemented custom logic in the function provided to the trainer and by default we can have the latest checkpoint as the best checkpoint.

@jsleep jsleep changed the title best <metric> checkpointing user defined save_best_checkpoint() hook Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants