Skip to content

Commit f56df24

Browse files
ali-hamudali-hamud
authoredMar 22, 2021
Merge pull request #375 from microsoft/version_2.18.0
Version 2.18.0
·
v2.19.1v2.18.0
2 parents df40b4e + a238e96 commit f56df24

28 files changed

+716
-176
lines changed
 

Diff for: ‎dist/powerbi-client.d.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
/*! powerbi-client v2.17.2 | (c) 2016 Microsoft Corporation MIT */
1+
// powerbi-client v2.18.0
2+
// Copyright (c) Microsoft Corporation.
3+
// Licensed under the MIT License.
24
declare module "util" {
35
import { HttpPostMessage } from 'http-post-message';
46
/**

Diff for: ‎dist/powerbi.js

+504-46
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎dist/powerbi.min.js

+5-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎gulpfile.js

+129-121
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,41 @@
1-
var gulp = require('gulp');
2-
var ghPages = require('gulp-gh-pages'),
3-
header = require('gulp-header'),
4-
help = require('gulp-help-four'),
5-
rename = require('gulp-rename'),
6-
replace = require('gulp-replace'),
7-
eslint = require("gulp-eslint"),
8-
ts = require('gulp-typescript'),
9-
flatten = require('gulp-flatten'),
10-
fs = require('fs'),
11-
del = require('del'),
12-
moment = require('moment'),
13-
karma = require('karma'),
14-
typedoc = require('gulp-typedoc'),
15-
watch = require('gulp-watch'),
16-
webpack = require('webpack'),
17-
webpackStream = require('webpack-stream'),
18-
webpackConfig = require('./webpack.config'),
19-
webpackTestConfig = require('./webpack.test.config'),
20-
runSequence = require('gulp4-run-sequence'),
21-
argv = require('yargs').argv;
22-
;
1+
const fs = require('fs');
2+
const gulp = require('gulp');
3+
const ghPages = require('gulp-gh-pages');
4+
const header = require('gulp-header');
5+
const help = require('gulp-help-four');
6+
const rename = require('gulp-rename');
7+
const replace = require('gulp-replace');
8+
const eslint = require("gulp-eslint");
9+
const ts = require('gulp-typescript');
10+
const flatten = require('gulp-flatten');
11+
const del = require('del');
12+
const moment = require('moment');
13+
const karma = require('karma');
14+
const typedoc = require('gulp-typedoc');
15+
const watch = require('gulp-watch');
16+
const webpack = require('webpack');
17+
const webpackStream = require('webpack-stream');
18+
const runSequence = require('gulp4-run-sequence');
19+
const webpackConfig = require('./webpack.config');
20+
const webpackTestConfig = require('./webpack.test.config');
21+
const argv = require('yargs').argv;
2322

2423
help(gulp, undefined);
2524

26-
var package = require('./package.json');
27-
var webpackBanner = package.name + " v" + package.version + " | (c) 2016 Microsoft Corporation " + package.license;
28-
var gulpBanner = "/*! " + webpackBanner + " */\n";
25+
const package = require('./package.json');
26+
const webpackBanner = "// " + package.name + " v" + package.version + "\n"
27+
+ "// Copyright (c) Microsoft Corporation.\n"
28+
+ "// Licensed under the MIT License.";
29+
const banner = webpackBanner + "\n";
2930

3031
gulp.task('ghpages', 'Deploy documentation to gh-pages', ['nojekyll'], function () {
31-
return gulp.src(['./docs/**/*'], {
32-
dot: true
33-
})
34-
.pipe(ghPages({
35-
force: true,
36-
message: 'Update ' + moment().format('LLL')
37-
}));
32+
return gulp.src(['./docs/**/*'], {
33+
dot: true
34+
})
35+
.pipe(ghPages({
36+
force: true,
37+
message: 'Update ' + moment().format('LLL')
38+
}));
3839
});
3940

4041
gulp.task("docs", 'Compile documentation from src code', function () {
@@ -64,105 +65,109 @@ gulp.task('copydemotodocs', 'Copy the demo to the docs', function () {
6465
});
6566

6667
gulp.task('nojekyll', 'Add .nojekyll file to docs directory', function (done) {
67-
fs.writeFile('./docs/.nojekyll', '', function (error) {
68-
if (error) {
69-
throw error;
70-
}
68+
fs.writeFile('./docs/.nojekyll', '', function (error) {
69+
if (error) {
70+
throw error;
71+
}
7172

72-
done();
73-
});
73+
done();
74+
});
7475
});
7576

7677
gulp.task('watch', 'Watches for changes', ['lint'], function () {
77-
gulp.watch(['./src/**/*.ts', './test/**/*.ts'], ['lint:ts']);
78-
gulp.watch(['./test/**/*.ts'], ['test']);
78+
gulp.watch(['./src/**/*.ts', './test/**/*.ts'], ['lint:ts']);
79+
gulp.watch(['./test/**/*.ts'], ['test']);
7980
});
8081

8182
gulp.task('lint', 'Lints all files', function (done) {
82-
runSequence(
83-
'lint:ts',
84-
done
85-
);
83+
runSequence(
84+
'lint:ts',
85+
done
86+
);
8687
});
8788

8889
gulp.task('test', 'Runs all tests', function (done) {
89-
runSequence(
90-
'lint:ts',
91-
'config',
92-
'compile:spec',
93-
'test:js',
94-
done
95-
);
90+
runSequence(
91+
'lint:ts',
92+
'config',
93+
'compile:spec',
94+
'test:js',
95+
done
96+
);
9697
});
9798

9899
gulp.task('build', 'Runs a full build', function (done) {
99-
runSequence(
100-
'lint:ts',
101-
'clean',
102-
'config',
103-
['compile:ts', 'compile:dts'],
104-
'min:js',
105-
'header',
106-
done
107-
);
100+
runSequence(
101+
'lint:ts',
102+
'clean',
103+
'config',
104+
['compile:ts', 'compile:dts'],
105+
'min:js',
106+
'header',
107+
done
108+
);
108109
});
109110

110111
gulp.task('build:docs', 'Build docs folder', function (done) {
111-
return runSequence(
112-
'clean:docs',
113-
'docs',
114-
'nojekyll',
115-
'copydemotodocs',
116-
done
117-
);
112+
return runSequence(
113+
'clean:docs',
114+
'docs',
115+
'nojekyll',
116+
'copydemotodocs',
117+
done
118+
);
118119
});
119120

120121
gulp.task('config', 'Update config version with package version', function () {
121-
return gulp.src(['./src/config.ts'], { base: "./" })
122-
.pipe(replace(/version: '([^']+)'/, `version: '${package.version}'`))
123-
.pipe(gulp.dest('.'));
122+
return gulp.src(['./src/config.ts'], { base: "./" })
123+
.pipe(replace(/version: '([^']+)'/, `version: '${package.version}'`))
124+
.pipe(gulp.dest('.'));
124125
});
125126

126127
gulp.task('header', 'Add header to distributed files', function () {
127-
return gulp.src(['./dist/*.d.ts'])
128-
.pipe(header(gulpBanner))
129-
.pipe(gulp.dest('./dist'));
128+
return gulp.src(['./dist/*.d.ts'])
129+
.pipe(header(banner))
130+
.pipe(gulp.dest('./dist'));
130131
});
131132

132133
gulp.task('clean', 'Cleans destination folder', function (done) {
133-
return del([
134-
'./dist/**/*'
135-
]);
134+
return del([
135+
'./dist/**/*'
136+
]);
136137
});
137138

138139
gulp.task('clean:docs', 'Clean docs directory', function () {
139-
return del([
140-
'docs/**/*',
141-
'docs'
142-
]);
140+
return del([
141+
'docs/**/*',
142+
'docs'
143+
]);
143144
});
144145

145146
gulp.task('lint:ts', 'Lints all TypeScript', function () {
146-
return gulp.src(['./src/**/*.ts', './test/**/*.ts'])
147-
.pipe(eslint({
148-
formatter: "verbose"
149-
}))
150-
.pipe(eslint.format());
147+
return gulp.src(['./src/**/*.ts', './test/**/*.ts'])
148+
.pipe(eslint({
149+
formatter: "verbose"
150+
}))
151+
.pipe(eslint.format());
151152
});
152153

153154
gulp.task('min:js', 'Creates minified JavaScript file', function () {
154155
webpackConfig.plugins = [
155-
new webpack.BannerPlugin(webpackBanner)
156+
new webpack.BannerPlugin({
157+
banner: webpackBanner,
158+
raw: true
159+
})
156160
];
157-
161+
158162
// Create minified bundle without source map
159163
webpackConfig.mode = 'production';
160-
webpackConfig.devtool = 'none'
164+
webpackConfig.devtool = 'none';
161165

162166
return gulp.src(['./src/powerbi-client.ts'])
163167
.pipe(webpackStream({
164168
config: webpackConfig
165169
}))
170+
.pipe(header(banner))
166171
.pipe(rename({
167172
suffix: '.min'
168173
}))
@@ -171,64 +176,67 @@ gulp.task('min:js', 'Creates minified JavaScript file', function () {
171176

172177
gulp.task('compile:ts', 'Compile typescript for powerbi-client library', function () {
173178
webpackConfig.plugins = [
174-
new webpack.BannerPlugin(webpackBanner)
179+
new webpack.BannerPlugin({
180+
banner: webpackBanner,
181+
raw: true
182+
})
175183
];
176184
webpackConfig.mode = "development";
177185

178-
return gulp.src(['./src/powerbi-client.ts'])
179-
.pipe(webpackStream(webpackConfig))
180-
.pipe(gulp.dest('dist/'));
186+
return gulp.src(['./src/powerbi-client.ts'])
187+
.pipe(webpackStream(webpackConfig))
188+
.pipe(gulp.dest('dist/'));
181189
});
182190

183191
gulp.task('compile:dts', 'Generate one dts file from modules', function () {
184-
var tsProject = ts.createProject('tsconfig.json', {
185-
declaration: true,
186-
sourceMap: false
187-
});
192+
const tsProject = ts.createProject('tsconfig.json', {
193+
declaration: true,
194+
sourceMap: false
195+
});
188196

189-
var settings = {
197+
const settings = {
190198
out: "powerbi-client.js",
191199
declaration: true,
192200
module: "system",
193201
moduleResolution: "node"
194202
};
195203

196-
var tsResult = tsProject.src()
197-
.pipe(ts(settings));
204+
const tsResult = tsProject.src()
205+
.pipe(ts(settings));
198206

199-
return tsResult.dts
200-
.pipe(flatten())
201-
.pipe(gulp.dest('./dist'));
207+
return tsResult.dts
208+
.pipe(flatten())
209+
.pipe(gulp.dest('./dist'));
202210
});
203211

204212
gulp.task('compile:spec', 'Compile spec tests', function () {
205-
return gulp.src(['./test/test.spec.ts'])
206-
.pipe(webpackStream(webpackTestConfig))
207-
.pipe(gulp.dest('./tmp'));
213+
return gulp.src(['./test/test.spec.ts'])
214+
.pipe(webpackStream(webpackTestConfig))
215+
.pipe(gulp.dest('./tmp'));
208216
});
209217

210218
gulp.task('test:js', 'Run js tests', function (done) {
211-
new karma.Server({
212-
configFile: __dirname + '/karma.conf.js',
213-
singleRun: argv.watch ? false : true,
214-
captureTimeout: argv.timeout || 60000
215-
}, function() {
216-
done();
219+
new karma.Server({
220+
configFile: __dirname + '/karma.conf.js',
221+
singleRun: argv.watch ? false : true,
222+
captureTimeout: argv.timeout || 60000
223+
}, function () {
224+
done();
217225
})
218-
.on('browser_register', (browser) => {
219-
if (argv.chrome) {
226+
.on('browser_register', (browser) => {
227+
if (argv.chrome) {
220228
browser.socket.on('disconnect', function (reason) {
221229
if (reason === "transport close" || reason === "transport error") {
222-
done(0);
223-
process.exit(0);
230+
done(0);
231+
process.exit(0);
224232
}
225-
});
226-
}
227-
})
228-
.start();
233+
});
234+
}
235+
})
236+
.start();
229237
if (argv.chrome) {
230238
return watch(["src/**/*.ts", "test/**/*.ts"], function () {
231-
runSequence('compile:spec');
239+
runSequence('compile:spec');
232240
});
233241
}
234-
});
242+
});

Diff for: ‎package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "powerbi-client",
3-
"version": "2.17.2",
3+
"version": "2.18.0",
44
"description": "JavaScript library for embedding Power BI into your apps. Provides service which makes it easy to embed different types of components and an object model which allows easy interaction with these components such as changing pages, applying filters, and responding to data selection.",
55
"main": "dist/powerbi.js",
66
"types": "dist/powerbi-client.d.ts",
@@ -81,7 +81,7 @@
8181
},
8282
"dependencies": {
8383
"http-post-message": "^0.2",
84-
"powerbi-models": "^1.8",
84+
"powerbi-models": "^1.9",
8585
"powerbi-router": "^0.1",
8686
"window-post-message-proxy": "^0.2"
8787
},

Diff for: ‎src/bookmarksManager.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
import {
25
BookmarksPlayMode,
36
IApplyBookmarkByNameRequest,

Diff for: ‎src/config.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
/** @ignore *//** */
25
const config = {
3-
version: '2.17.2',
6+
version: '2.18.0',
47
type: 'js'
58
};
69

Diff for: ‎src/create.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
import { IReportCreateConfiguration, IError, validateCreateReport } from 'powerbi-models';
25
import { Service } from './service';
36
import { Embed, IEmbedConfigurationBase, IEmbedConfiguration } from './embed';

Diff for: ‎src/dashboard.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
import { IError, validateDashboardLoad, PageView } from 'powerbi-models';
25
import { Service, IService } from './service';
36
import { Embed, IDashboardEmbedConfiguration, IEmbedConfigurationBase } from './embed';

Diff for: ‎src/embed.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
import * as models from 'powerbi-models';
25
import { addParamToUrl, assign, autoAuthInEmbedUrl, createRandomString, getTimeDiffInMilliseconds, remove } from './util';
36
import { Service, IEventHandler, IEvent, ICustomEvent } from './service';

Diff for: ‎src/errors.ts

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
13

24
export const APINotSupportedForRDLError = "This API is currently not supported for RDL reports";
35
export const EmbedUrlNotSupported = "Embed URL is invalid for this scenario. Please use Power BI REST APIs to get the valid URL";

Diff for: ‎src/factories.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
/**
25
* TODO: Need to find better place for these factory functions or refactor how we handle dependency injection
36
*/

Diff for: ‎src/ifilterable.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
import { FiltersOperations, IFilter } from 'powerbi-models';
25
import { IHttpPostMessageResponse } from 'http-post-message';
36

Diff for: ‎src/page.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
import { IHttpPostMessageResponse } from 'http-post-message';
25
import {
36
DisplayOption,

Diff for: ‎src/powerbi-client.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
/**
25
* @hidden
36
*/

Diff for: ‎src/qna.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
import { IHttpPostMessageResponse } from 'http-post-message';
25
import { IError, IQnaInterpretInputData, validateLoadQnaConfiguration } from 'powerbi-models';
36
import { Embed, IEmbedConfigurationBase } from './embed';

Diff for: ‎src/report.ts

+7
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
import {
25
IReportLoadConfiguration,
36
IReportEmbedConfiguration,
@@ -11,6 +14,7 @@ import {
1114
LayoutType,
1215
SectionVisibility,
1316
validateReportLoad,
17+
validatePaginatedReportLoad,
1418
ViewMode,
1519
IEmbedConfiguration,
1620
IEmbedConfigurationBase,
@@ -434,6 +438,9 @@ export class Report extends Embed implements IReportNode, IFilterable {
434438
* @hidden
435439
*/
436440
validate(config: IEmbedConfigurationBase): IError[] {
441+
if (isRDLEmbed(this.config.embedUrl)) {
442+
return validatePaginatedReportLoad(config);
443+
}
437444
return validateReportLoad(config);
438445
}
439446

Diff for: ‎src/service.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
/* eslint-disable @typescript-eslint/prefer-function-type */
25
/* eslint-disable @typescript-eslint/no-unused-vars */
36
/* eslint-disable @typescript-eslint/no-unsafe-assignment */

Diff for: ‎src/tile.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
import { IError, validateTileLoad } from 'powerbi-models';
25
import { Service } from './service';
36
import { Embed, IEmbedConfigurationBase, ITileEmbedConfiguration } from './embed';

Diff for: ‎src/util.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
import { HttpPostMessage } from 'http-post-message';
25

36
/**

Diff for: ‎src/visual.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
import {
25
DisplayOption,
36
FiltersLevel,

Diff for: ‎src/visualDescriptor.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
import {
25
ExportDataType,
36
FiltersOperations,

Diff for: ‎test/test.spec.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
import * as utils from '../src/util';
25
import * as service from '../src/service';
36
import * as embed from '../src/embed';

Diff for: ‎test/utility/mockApp.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
import * as models from 'powerbi-models';
25

36
export interface IApp {

Diff for: ‎test/utility/mockEmbed.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
import * as Wpmp from 'window-post-message-proxy';
25
import * as Hpm from 'http-post-message';
36
import * as Router from 'powerbi-router';

Diff for: ‎test/utility/mockHpm.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
export const spyHpm = {
25
get: jasmine.createSpy("get").and.returnValue(Promise.resolve(null)),
36
post: jasmine.createSpy("post").and.returnValue(Promise.resolve(null)),

Diff for: ‎test/utility/mockRouter.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
export const spyRouter = {
25
get: jasmine.createSpy("get"),
36
post: jasmine.createSpy("post"),

Diff for: ‎test/utility/mockWpmp.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Copyright (c) Microsoft Corporation.
2+
// Licensed under the MIT License.
3+
14
export const spyWpmp = {
25
handlers: [],
36

0 commit comments

Comments
 (0)
Please sign in to comment.