Skip to content

Commit 918a7e7

Browse files
authored
Merge pull request #155 from Microsoft/alihamud/liveSampleTweaks
Enable enter edit mode when starting with view mode
2 parents 5e71461 + 70ef486 commit 918a7e7

File tree

3 files changed

+17
-11
lines changed

3 files changed

+17
-11
lines changed

demo/code-demo/scripts/codesamples.js

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,12 @@ function _Embed_BasicEmbed() {
1616
// Read report Id from textbox
1717
var txtEmbedReportId = $('#txtEmbedReportId').val();
1818

19+
// Get models. models contains enums that can be used.
20+
var models = window['powerbi-client'].models;
21+
22+
// We give All permissions to demonstrate switching between View and Edit mode and saving report.
23+
var permissions = models.Permissions.All;
24+
1925
// Embed configuration used to describe the what and how to embed.
2026
// This object is used when calling powerbi.embed.
2127
// This also includes settings and options such as filters.
@@ -25,6 +31,7 @@ function _Embed_BasicEmbed() {
2531
accessToken: txtAccessToken,
2632
embedUrl: txtEmbedUrl,
2733
id: txtEmbedReportId,
34+
permissions: permissions,
2835
settings: {
2936
filterPaneEnabled: true,
3037
navContentPaneEnabled: true
@@ -64,7 +71,7 @@ function _Mock_Embed_BasicEmbed(isEdit) {
6471

6572
// Get models. models contains enums that can be used.
6673
var models = window['powerbi-client'].models;
67-
var permissions = isEdit ? models.Permissions.Copy : models.Permissions.Read;
74+
var permissions = models.Permissions.Copy | models.Permissions.Read;
6875
var viewMode = isEdit ? models.ViewMode.Edit : models.ViewMode.View;
6976

7077
// Embed configuration used to describe the what and how to embed.
@@ -107,8 +114,8 @@ function _Mock_Embed_BasicEmbed(isEdit) {
107114
report.on("error", function(event) {
108115
Log.log(event.detail);
109116
});
110-
111-
report.off("saved");
117+
118+
report.off("saved");
112119
report.on("saved", function(event) {
113120
Log.log(event.detail);
114121
if(event.detail.saveAs) {
@@ -169,12 +176,12 @@ function _Embed_BasicEmbed_EditMode() {
169176
Log.logText("Loaded");
170177
});
171178

172-
report.off("error");
179+
report.off("error");
173180
report.on("error", function(event) {
174181
Log.log(event.detail);
175182
});
176-
177-
report.off("saved");
183+
184+
report.off("saved");
178185
report.on("saved", function(event) {
179186
Log.log(event.detail);
180187
if(event.detail.saveAs) {
@@ -730,4 +737,4 @@ function _Events_SaveAsTriggered() {
730737
// You should see an entry in the Log window.
731738

732739
Log.logText("Select SaveAs to see events in Log window.");
733-
}
740+
}

demo/code-demo/scripts/index.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ $(function() {
66
OpenSampleSection();
77
});
88

9-
function OpenSampleSection()
10-
{
9+
function OpenSampleSection() {
1110
if (!sampleContentLoaded)
1211
{
1312
// Open Report Sample.
@@ -21,8 +20,7 @@ function OpenSampleSection()
2120
$("#sampleContent").show();
2221
}
2322

24-
function OpenDocumentationSection()
25-
{
23+
function OpenDocumentationSection() {
2624
if (!documentationContentLoaded)
2725
{
2826
$("#documentationContent").load("docs.html");

demo/code-demo/scripts/report.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ function OpenInteractStep() {
4848
SetToggleHandler("report-operations-div");
4949
SetToggleHandler("page-operations-div");
5050
SetToggleHandler("events-operations-div");
51+
SetToggleHandler("editandsave-operations-div");
5152
LoadCodeArea("#embedCodeDiv", _Report_GetId);
5253
});
5354
}

0 commit comments

Comments
 (0)