Skip to content

Commit 194de2f

Browse files
author
Shahak Yosef
committed
Merged PR 136313: 2.16.3 global this
Between versions 2.15.1 and 2.16.1 Webpack version was updated which caused the compiled JS code to use the window object instead of the global `this` object. `window` object is not defined in Node.JS so when I tried to update the version used by the front end E2E tests I got the following error: It might also be the reason why the travis build fails the `npm install` in Github. ![e2e.PNG](https://powerbi.visualstudio.com/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/136311/attachments/e2e.PNG)
1 parent d7b0853 commit 194de2f

File tree

6 files changed

+10
-9
lines changed

6 files changed

+10
-9
lines changed

Diff for: dist/powerbi-client.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! powerbi-client v2.16.2 | (c) 2016 Microsoft Corporation MIT */
1+
/*! powerbi-client v2.16.3 | (c) 2016 Microsoft Corporation MIT */
22
declare module "util" {
33
import { HttpPostMessage } from 'http-post-message';
44
/**

Diff for: dist/powerbi.js

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: dist/powerbi.min.js

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "powerbi-client",
3-
"version": "2.16.2",
3+
"version": "2.16.3",
44
"description": "JavaScript library for embedding Power BI into your apps. Provides service which makes it easy to embed different types of components and an object model which allows easy interaction with these components such as changing pages, applying filters, and responding to data selection.",
55
"main": "dist/powerbi.js",
66
"types": "dist/powerbi-client.d.ts",

Diff for: src/config.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/** @ignore *//** */
22
const config = {
3-
version: '2.16.2',
3+
version: '2.16.3',
44
type: 'js'
55
};
66

Diff for: webpack.config.js

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ module.exports = {
55
'powerbi': './src/powerbi-client.ts'
66
},
77
output: {
8+
globalObject: "this",
89
path: __dirname + "/dist",
910
filename: '[name].js',
1011
library: package.name,

0 commit comments

Comments
 (0)