Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problematic call to HttpClient when trying to determine the media type #1953

Closed
darrelmiller opened this issue Nov 25, 2024 · 0 comments
Closed

Problematic call to HttpClient when trying to determine the media type #1953

darrelmiller opened this issue Nov 25, 2024 · 0 comments
Labels
priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days
Milestone
v2-Preview17

Comments

@darrelmiller
Copy link
Member

OpenAPI.NET/src/Microsoft.OpenApi/Reader/OpenApiModelFactory.cs

Line 265 in df5d0c7

var response = _httpClient.GetAsync(url).GetAwaiter().GetResult();

This can't hide a potentially expensive HTTP request inside a method like this. We are going to have to find another way of accessing the media type.
@darrelmiller darrelmiller added this to the NET:2.0 milestone Nov 26, 2024
@darrelmiller darrelmiller added the priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days
Projects
None yet
Milestone
v2-Preview17
Development

No branches or pull requests
1 participant
@darrelmiller