Remove/fix most of the ESLint exceptions in Container (#884)

Author: ChumpChief

packages/loader/container-loader/src/container.ts

@@ -3,9 +3,6 @@
  * Licensed under the MIT License.
  */
 
-// Disabling these per-file rather than full subdirectory
-/* eslint-disable @typescript-eslint/no-misused-promises */
-
 import * as assert from "assert";
 import {
     ITelemetryBaseLogger,
@@ -118,8 +115,7 @@ export class Container extends EventEmitterWithErrorHandling implements IContain
             request,
             logger);
 
-        // eslint-disable-next-line no-async-promise-executor
-        return new Promise<Container>(async (res, rej) => {
+        return new Promise<Container>((res, rej) => {
             let alreadyRaisedError = false;
             const onError = (error) => {
                 container.removeListener("error", onError);
@@ -135,8 +131,7 @@ export class Container extends EventEmitterWithErrorHandling implements IContain
             const version = request.headers && request.headers[LoaderHeader.version];
             const pause = request.headers && request.headers[LoaderHeader.pause];
 
-            // tslint:disable-next-line no-unsafe-any
-            return container.load(version, !!pause)
+            container.load(version, !!pause)
                 .then(() => {
                     container.removeListener("error", onError);
                     res(container);
@@ -156,10 +151,6 @@ export class Container extends EventEmitterWithErrorHandling implements IContain
 
     private pendingClientId: string | undefined;
     private loaded = false;
-    // TSLint incorrectly believes blobManager is not reassigned, but actually it is in load().
-    // Known bug: https://github.com/palantir/tslint/issues/3803
-    // Fixed in ESLint: https://github.com/typescript-eslint/typescript-eslint/issues/946
-    // tslint:disable-next-line:prefer-readonly
     private blobManager: BlobManager | undefined;
 
     // Active chaincode and associated runtime
@@ -179,10 +170,6 @@ export class Container extends EventEmitterWithErrorHandling implements IContain
     private context: ContainerContext | undefined;
     private pkg: string | IFluidCodeDetails | undefined;
     private codeQuorumKey;
-    // TSLint incorrectly believes protocolHandler is not reassigned, but actually it is in load().
-    // Known bug: https://github.com/palantir/tslint/issues/3803
-    // Fixed in ESLint: https://github.com/typescript-eslint/typescript-eslint/issues/946
-    // tslint:disable-next-line:prefer-readonly
     private protocolHandler: ProtocolOpHandler | undefined;
 
     private firstConnection = true;
@@ -349,7 +336,6 @@ export class Container extends EventEmitterWithErrorHandling implements IContain
     public on(event: "pong" | "processTime", listener: (latency: number) => void): this;
     public on(event: MessageType.BlobUploaded, listener: (contents: any) => void): this;
 
-    /* tslint:disable:no-unnecessary-override */
     public on(event: string | symbol, listener: (...args: any[]) => void): this {
         return super.on(event, listener);
     }
@@ -431,8 +417,7 @@ export class Container extends EventEmitterWithErrorHandling implements IContain
         this.emit("error", error);
     }
 
-    // eslint-disable-next-line @typescript-eslint/promise-function-async
-    public reloadContext(): Promise<void> {
+    public async reloadContext(): Promise<void> {
         return this.reloadContextCore().catch((error) => {
             this.raiseCriticalError(error);
             throw error;
@@ -770,7 +755,6 @@ export class Container extends EventEmitterWithErrorHandling implements IContain
         });
 
         protocol.quorum.on("error", (error) => {
-            // tslint:disable-next-line no-unsafe-any
             protocolLogger.sendErrorEvent(error);
         });
 
@@ -877,9 +861,7 @@ export class Container extends EventEmitterWithErrorHandling implements IContain
     }
 
     private get client() {
-        // tslint:disable-next-line:no-unsafe-any
         const client: IClient = this.options && this.options.client
-            // tslint:disable-next-line:no-unsafe-any
             ? (this.options.client as IClient)
             : {
                 type: "browser", // Back-compat: 0.11 clientType
@@ -896,7 +878,6 @@ export class Container extends EventEmitterWithErrorHandling implements IContain
             && this.originalRequest.headers[LoaderHeader.clientDetails];
 
         if (headerClientDetails) {
-            // tslint:disable-next-line: no-unsafe-any
             merge(client.details, headerClientDetails);
         }
 
@@ -1145,13 +1126,10 @@ export class Container extends EventEmitterWithErrorHandling implements IContain
         }
     }
 
-    // tslint:disable no-unsafe-any
     private getScopes(options: any): string[] {
         return options && options.tokens && options.tokens.jwt ?
-            // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
-            (jwtDecode(options.tokens.jwt) as ITokenClaims).scopes : [];
+            jwtDecode<ITokenClaims>(options.tokens.jwt).scopes : [];
     }
-    // tslint:enable no-unsafe-any
 
     /**
      * Get the most recent snapshot, or a specific version.
@@ -1198,8 +1176,7 @@ export class Container extends EventEmitterWithErrorHandling implements IContain
             (err) => this.raiseCriticalError(err),
             (type, contents) => this.submitMessage(type, contents),
             (message) => this.submitSignal(message),
-            // eslint-disable-next-line @typescript-eslint/promise-function-async
-            (message) => this.snapshot(message),
+            async (message) => this.snapshot(message),
             (reason?: string) => this.close(reason),
             Container.version,
         );