Skip to content

Commit 161df0f

Browse files
committed
fix test and pylint issue
1 parent 9a7ec69 commit 161df0f

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

samples/feature_variant_sample_with_targeting_accessor.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@
1616
with open(script_directory + "/formatted_feature_flags.json", "r", encoding="utf-8") as f:
1717
feature_flags = json.load(f)
1818

19-
user_id = "Adam"
19+
USER_ID = "Adam"
2020

2121

2222
def my_targeting_accessor() -> TargetingContext:
23-
return TargetingContext(user_id=user_id)
23+
return TargetingContext(user_id=USER_ID)
2424

2525

2626
feature_manager = FeatureManager(
@@ -30,7 +30,7 @@ def my_targeting_accessor() -> TargetingContext:
3030
print(feature_manager.is_enabled("TestVariants"))
3131
print(feature_manager.get_variant("TestVariants").configuration)
3232

33-
user_id = "Ellie"
33+
USER_ID = "Ellie"
3434

3535
print(feature_manager.is_enabled("TestVariants"))
3636
print(feature_manager.get_variant("TestVariants").configuration)

tests/test_default_feature_flags_async.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -311,6 +311,8 @@ def my_targeting_accessor() -> TargetingContext:
311311
user_id = "Belle"
312312
assert not await feature_manager.is_enabled("Target")
313313
# Belle is enabled because all of Stage 1 is enabled
314-
assert await feature_manager.is_enabled("Target", TargetingContext(user_id="Belle", groups=["Stage1"]))
314+
group_id = "Stage1"
315+
assert await feature_manager.is_enabled("Target")
315316
# Belle is not enabled because he is not in Stage 2, group isn't looked at when user is targeted
316-
assert not await feature_manager.is_enabled("Target", TargetingContext(user_id="Belle", groups=["Stage2"]))
317+
group_id = "Stage2"
318+
assert not await feature_manager.is_enabled("Target")

0 commit comments

Comments
 (0)