Skip to content

Settings: no per-row spinner when an import-triggered or queued upgrade runs #525

@jschick04

Description

@jschick04

Summary

When a database upgrade is triggered from inside the Settings modal (Import Database brings in a file whose schema needs upgrading, or the user clicks Upgrade on a row), there is no in-modal indication that work is happening on that row. The Upgrade button stays as-is and the row looks idle while the upgrade runs in the background.

Repro

  1. Open Settings.
  2. Either click Import Database and pick a file requiring an upgrade, or click Upgrade on an Upgrade Required row.
  3. Watch the row.

Expected

The row's primary action visibly switches to a spinner / progress indicator (and ideally shows the current phase) while the upgrade is in flight, matching the banner behavior outside Settings.

Actual

The Upgrade button stays rendered and clickable-looking. There is a modal-top progress banner (SettingsUpgradeProgressBanner) but the row itself does not change state, so it is not obvious which row is being worked on or that anything is happening when the user is looking at the row.

Notes

DatabaseEntryRow already has an ActionKind.Spinner branch driven by IsUpgrading, but SettingsModal only adds entries to _entriesUpgrading for upgrades it kicked off itself. Imports and queued upgrades from elsewhere do not flip the row into the spinner state.

src/EventLogExpert.Components/Database/DatabaseEntryRow.razor.cs lines 49-70.
src/EventLogExpert.Components/Modals/SettingsModal.razor.cs (ImportDatabase, UpgradeEntry, _entriesUpgrading).

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions