Skip to content

header-parser: add reviewer #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elibarzilay opened this issue Jan 28, 2021 · 0 comments
Open

header-parser: add reviewer #198

elibarzilay opened this issue Jan 28, 2021 · 0 comments

Comments

@elibarzilay
Copy link

Related to DefinitelyTyped/dt-mergebot#248: when this was discussed, the conclusion was that there's no good way to guess when an owner approval is required, and therefore the header should be extended with an optional field for the required approval level. The value should be owner or maintainer.

(Maybe for completeness allow other too? The parser can just ignore the actual value, and leave that for the mergebot to decide what to do with it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant