Skip to content

Commit a5f9371

Browse files
committed
Changed views default to match otel
1 parent 7af8989 commit a5f9371

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

azure-monitor-opentelemetry/azure/monitor/opentelemetry/util/configurations.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ def _default_metric_readers(configurations):
173173

174174
def _default_views(configurations):
175175
if VIEWS_ARG not in configurations:
176-
configurations[VIEWS_ARG] = []
176+
configurations[VIEWS_ARG] = ()
177177

178178

179179
# TODO: remove when sampler uses env var instead

azure-monitor-opentelemetry/tests/configuration/test_util.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ def test_get_configurations_defaults(self):
9595
self.assertEqual(configurations["tracing_export_interval_ms"], None)
9696
self.assertEqual(configurations["logging_export_interval_ms"], 5000)
9797
self.assertEqual(configurations["metric_readers"], [])
98-
self.assertEqual(configurations["views"], [])
98+
self.assertEqual(configurations["views"], ())
9999
self.assertEqual(configurations["instrumentation_config"], {})
100100

101101
def test_get_configurations_validation(self):
@@ -140,7 +140,7 @@ def test_get_configurations_env_vars(self):
140140
self.assertEqual(configurations["tracing_export_interval_ms"], None)
141141
self.assertEqual(configurations["logging_export_interval_ms"], 10000)
142142
self.assertEqual(configurations["metric_readers"], [])
143-
self.assertEqual(configurations["views"], [])
143+
self.assertEqual(configurations["views"], ())
144144
self.assertEqual(
145145
configurations["instrumentation_config"],
146146
{"flask": {"excluded_urls": "http://localhost:8080/ignore"}},
@@ -178,7 +178,7 @@ def test_get_configurations_env_vars_validation(self):
178178
self.assertEqual(configurations["tracing_export_interval_ms"], None)
179179
self.assertEqual(configurations["logging_export_interval_ms"], 5000)
180180
self.assertEqual(configurations["metric_readers"], [])
181-
self.assertEqual(configurations["views"], [])
181+
self.assertEqual(configurations["views"], ())
182182
self.assertEqual(configurations["instrumentation_config"], {})
183183

184184
@patch.dict(
@@ -205,7 +205,7 @@ def test_get_configurations_env_vars_false(self):
205205
self.assertEqual(configurations["tracing_export_interval_ms"], None)
206206
self.assertEqual(configurations["logging_export_interval_ms"], 5000)
207207
self.assertEqual(configurations["metric_readers"], [])
208-
self.assertEqual(configurations["views"], [])
208+
self.assertEqual(configurations["views"], ())
209209
self.assertEqual(configurations["instrumentation_config"], {})
210210

211211
@patch.dict(
@@ -232,5 +232,5 @@ def test_get_configurations_env_vars_true(self):
232232
self.assertEqual(configurations["tracing_export_interval_ms"], None)
233233
self.assertEqual(configurations["logging_export_interval_ms"], 5000)
234234
self.assertEqual(configurations["metric_readers"], [])
235-
self.assertEqual(configurations["views"], [])
235+
self.assertEqual(configurations["views"], ())
236236
self.assertEqual(configurations["instrumentation_config"], {})

0 commit comments

Comments
 (0)