Skip to content

Commit 22a14b0

Browse files
authored
1 parent 7ccd1e0 commit 22a14b0

File tree

96 files changed

+8665
-4415
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

96 files changed

+8665
-4415
lines changed

.github/AL-Go-Settings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"runs-on": "windows-latest",
77
"cacheImageName": "",
88
"UsePsSession": false,
9-
"artifact": "https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/28.0.40558.0/base",
9+
"artifact": "https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/28.0.40773.0/base",
1010
"country": "base",
1111
"useProjectDependencies": true,
1212
"repoVersion": "28.0",

Apps/AT/ContosoCoffeeDemoDatasetAT/app/DemoData/Finance/1. Setup Data/CreateATGLAccount.Codeunit.al

Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -352,11 +352,6 @@ codeunit 11148 "Create AT GL Account"
352352
ContosoGLAccount.InsertGLAccount(ProjectCostsCorrection(), ProjectCostsCorrectionName(), Enum::"G/L Account Income/Balance"::"Income Statement", Enum::"G/L Account Category"::"Cost of Goods Sold", Enum::"G/L Account Type"::Posting, '', '', 0, '', Enum::"General Posting Type"::" ", '', '', true, false, false);
353353
ContosoGLAccount.InsertGLAccount(TotalProjects(), TotalProjectsName(), Enum::"G/L Account Income/Balance"::"Income Statement", Enum::"G/L Account Category"::"Cost of Goods Sold", Enum::"G/L Account Type"::"End-Total", '', '', 0, '5250..5299', Enum::"General Posting Type"::" ", '', '', false, false, false);
354354
ContosoGLAccount.InsertGLAccount(Variance(), VarianceName(), Enum::"G/L Account Income/Balance"::"Income Statement", Enum::"G/L Account Category"::"Cost of Goods Sold", Enum::"G/L Account Type"::"Begin-Total", '', '', 0, '', Enum::"General Posting Type"::" ", '', '', false, false, false);
355-
ContosoGLAccount.InsertGLAccount(MaterialVariance(), MaterialVarianceName(), Enum::"G/L Account Income/Balance"::"Income Statement", Enum::"G/L Account Category"::"Cost of Goods Sold", Enum::"G/L Account Type"::Posting, '', '', 0, '', Enum::"General Posting Type"::" ", '', '', true, false, false);
356-
ContosoGLAccount.InsertGLAccount(CapacityVariance(), CapacityVarianceName(), Enum::"G/L Account Income/Balance"::"Income Statement", Enum::"G/L Account Category"::"Cost of Goods Sold", Enum::"G/L Account Type"::Posting, '', '', 0, '', Enum::"General Posting Type"::" ", '', '', true, false, false);
357-
ContosoGLAccount.InsertGLAccount(SubcontractedVariance(), SubcontractedVarianceName(), Enum::"G/L Account Income/Balance"::"Income Statement", Enum::"G/L Account Category"::"Cost of Goods Sold", Enum::"G/L Account Type"::Posting, '', '', 0, '', Enum::"General Posting Type"::" ", '', '', true, false, false);
358-
ContosoGLAccount.InsertGLAccount(CapOverheadVariance(), CapOverheadVarianceName(), Enum::"G/L Account Income/Balance"::"Income Statement", Enum::"G/L Account Category"::"Cost of Goods Sold", Enum::"G/L Account Type"::Posting, '', '', 0, '', Enum::"General Posting Type"::" ", '', '', true, false, false);
359-
ContosoGLAccount.InsertGLAccount(ManufacturingOverheadVariance(), ManufacturingOverheadVarianceName(), Enum::"G/L Account Income/Balance"::"Income Statement", Enum::"G/L Account Category"::"Cost of Goods Sold", Enum::"G/L Account Type"::Posting, '', '', 0, '', Enum::"General Posting Type"::" ", '', '', true, false, false);
360355
ContosoGLAccount.InsertGLAccount(TotalVariance(), TotalVarianceName(), Enum::"G/L Account Income/Balance"::"Income Statement", Enum::"G/L Account Category"::"Cost of Goods Sold", Enum::"G/L Account Type"::"End-Total", '', '', 0, '5300..5399', Enum::"General Posting Type"::" ", '', '', false, false, false);
361356
ContosoGLAccount.InsertGLAccount(Consumption(), ConsumptionName(), Enum::"G/L Account Income/Balance"::"Income Statement", Enum::"G/L Account Category"::"Cost of Goods Sold", Enum::"G/L Account Type"::"Begin-Total", '', '', 0, '', Enum::"General Posting Type"::" ", '', '', false, false, false);
362357
ContosoGLAccount.InsertGLAccount(AuxiliariesConsumption(), AuxiliariesConsumptionName(), Enum::"G/L Account Income/Balance"::"Income Statement", Enum::"G/L Account Category"::"Cost of Goods Sold", Enum::"G/L Account Type"::Posting, '', '', 0, '', Enum::"General Posting Type"::" ", '', '', true, false, false);
@@ -867,11 +862,6 @@ codeunit 11148 "Create AT GL Account"
867862
ContosoGLAccount.AddAccountForLocalization(ProjectCostsCorrectionName(), '5280');
868863
ContosoGLAccount.AddAccountForLocalization(TotalProjectsName(), '5299');
869864
ContosoGLAccount.AddAccountForLocalization(VarianceName(), '5300');
870-
ContosoGLAccount.AddAccountForLocalization(MaterialVarianceName(), '5310');
871-
ContosoGLAccount.AddAccountForLocalization(CapacityVarianceName(), '5320');
872-
ContosoGLAccount.AddAccountForLocalization(SubcontractedVarianceName(), '5330');
873-
ContosoGLAccount.AddAccountForLocalization(CapOverheadVarianceName(), '5340');
874-
ContosoGLAccount.AddAccountForLocalization(ManufacturingOverheadVarianceName(), '5350');
875865
ContosoGLAccount.AddAccountForLocalization(TotalVarianceName(), '5399');
876866
ContosoGLAccount.AddAccountForLocalization(ConsumptionName(), '5400');
877867
ContosoGLAccount.AddAccountForLocalization(AuxiliariesConsumptionName(), '5410');
@@ -2853,31 +2843,37 @@ codeunit 11148 "Create AT GL Account"
28532843
exit(VarianceLbl);
28542844
end;
28552845

2846+
#if not CLEAN28
2847+
[Obsolete('Unused function.', '28.0')]
28562848
procedure MaterialVarianceName(): Text[100]
28572849
begin
28582850
exit(MaterialVarianceLbl);
28592851
end;
28602852

2853+
[Obsolete('Unused function.', '28.0')]
28612854
procedure CapacityVarianceName(): Text[100]
28622855
begin
28632856
exit(CapacityVarianceLbl);
28642857
end;
28652858

2859+
[Obsolete('Unused function.', '28.0')]
28662860
procedure SubcontractedVarianceName(): Text[100]
28672861
begin
28682862
exit(SubcontractedVarianceLbl);
28692863
end;
28702864

2865+
[Obsolete('Unused function.', '28.0')]
28712866
procedure CapOverheadVarianceName(): Text[100]
28722867
begin
28732868
exit(CapOverheadVarianceLbl);
28742869
end;
28752870

2871+
[Obsolete('Unused function.', '28.0')]
28762872
procedure ManufacturingOverheadVarianceName(): Text[100]
28772873
begin
28782874
exit(ManufacturingOverheadVarianceLbl);
28792875
end;
2880-
2876+
#endif
28812877
procedure TotalVarianceName(): Text[100]
28822878
begin
28832879
exit(TotalVarianceLbl);
@@ -5203,31 +5199,37 @@ codeunit 11148 "Create AT GL Account"
52035199
exit(ContosoGLAccount.GetAccountNo(VarianceName()));
52045200
end;
52055201

5202+
#if not CLEAN28
5203+
[Obsolete('Unused function.', '28.0')]
52065204
procedure MaterialVariance(): Code[20]
52075205
begin
52085206
exit(ContosoGLAccount.GetAccountNo(MaterialVarianceName()));
52095207
end;
52105208

5209+
[Obsolete('Unused function.', '28.0')]
52115210
procedure CapacityVariance(): Code[20]
52125211
begin
52135212
exit(ContosoGLAccount.GetAccountNo(CapacityVarianceName()));
52145213
end;
52155214

5215+
[Obsolete('Unused function.', '28.0')]
52165216
procedure SubcontractedVariance(): Code[20]
52175217
begin
52185218
exit(ContosoGLAccount.GetAccountNo(SubcontractedVarianceName()));
52195219
end;
52205220

5221+
[Obsolete('Unused function.', '28.0')]
52215222
procedure CapOverheadVariance(): Code[20]
52225223
begin
52235224
exit(ContosoGLAccount.GetAccountNo(CapOverheadVarianceName()));
52245225
end;
52255226

5227+
[Obsolete('Unused function.', '28.0')]
52265228
procedure ManufacturingOverheadVariance(): Code[20]
52275229
begin
52285230
exit(ContosoGLAccount.GetAccountNo(ManufacturingOverheadVarianceName()));
52295231
end;
5230-
5232+
#endif
52315233
procedure TotalVariance(): Code[20]
52325234
begin
52335235
exit(ContosoGLAccount.GetAccountNo(TotalVarianceName()));
@@ -6426,11 +6428,13 @@ codeunit 11148 "Create AT GL Account"
64266428
ProjectCostsCorrectionLbl: Label 'Project costs correction', MaxLength = 100;
64276429
TotalProjectsLbl: Label 'Total projects', MaxLength = 100;
64286430
VarianceLbl: Label 'Variance', MaxLength = 100;
6431+
#if not CLEAN28
64296432
MaterialVarianceLbl: Label 'Material variance', MaxLength = 100;
64306433
CapacityVarianceLbl: Label 'Capacity variance', MaxLength = 100;
64316434
SubcontractedVarianceLbl: Label 'Subcontracted variance', MaxLength = 100;
64326435
CapOverheadVarianceLbl: Label 'Cap. overhead variance', MaxLength = 100;
6433-
ManufacturingOverheadVarianceLbl: Label 'Manufacturing overhead variance', MaxLength = 100;
6436+
ManufacturingOverheadVarianceLbl: Label 'Manufacturing overhead variance', MaxLength = 100;
6437+
#endif
64346438
TotalVarianceLbl: Label 'Total variance', MaxLength = 100;
64356439
ConsumptionLbl: Label 'Consumption', MaxLength = 100;
64366440
AuxiliariesConsumptionLbl: Label 'Auxiliaries consumption', MaxLength = 100;

Apps/AU/ContosoCoffeeDemoDatasetAU/app/DemoData/AUContosoLocalization.Codeunit.al

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -67,17 +67,10 @@ codeunit 17131 "AU Contoso Localization"
6767
end;
6868

6969
local procedure InventoryModule(ContosoDemoDataLevel: Enum "Contoso Demo Data Level")
70-
var
71-
CreateAUInvPostingSetup: Codeunit "Create AU Inv Posting Setup";
7270
begin
7371
case ContosoDemoDataLevel of
7472
Enum::"Contoso Demo Data Level"::"Setup Data":
75-
begin
76-
Codeunit.Run(Codeunit::"Create AU Inv Posting Group");
77-
Codeunit.Run(Codeunit::"Create AU Inv Posting Setup");
78-
end;
79-
Enum::"Contoso Demo Data Level"::"Master Data":
80-
CreateAUInvPostingSetup.UpdateInventoryPosting();
73+
Codeunit.Run(Codeunit::"Create AU Inv Posting Group");
8174
end;
8275
end;
8376

@@ -181,7 +174,6 @@ codeunit 17131 "AU Contoso Localization"
181174
local procedure OnBeforeGeneratingDemoData(ContosoDemoDataLevel: Enum "Contoso Demo Data Level"; Module: Enum "Contoso Demo Data Module")
182175
var
183176
FinanceModuleSetup: Record "Finance Module Setup";
184-
CreateAUInvPostingSetup: Codeunit "Create AU Inv Posting Setup";
185177
CreateAUBankAccPostingGrp: Codeunit "Create AU Bank Acc Posting Grp";
186178
CreateAUPaymentMethod: Codeunit "Create AU Payment Method";
187179
CreateAUBankAccount: Codeunit "Create AU Bank Account";
@@ -226,7 +218,6 @@ codeunit 17131 "AU Contoso Localization"
226218
Enum::"Contoso Demo Data Module"::Inventory:
227219
begin
228220
BindSubscription(CreateAULocation);
229-
BindSubscription(CreateAUInvPostingSetup);
230221
BindSubscription(CreateAUItem);
231222
end;
232223
Enum::"Contoso Demo Data Module"::Bank:
@@ -260,7 +251,6 @@ codeunit 17131 "AU Contoso Localization"
260251
[EventSubscriber(ObjectType::Codeunit, Codeunit::"Contoso Demo Tool", 'OnAfterGeneratingDemoData', '', false, false)]
261252
local procedure OnAfterGeneratingDemoData(ContosoDemoDataLevel: Enum "Contoso Demo Data Level"; Module: Enum "Contoso Demo Data Module")
262253
var
263-
CreateAUInvPostingSetup: Codeunit "Create AU Inv Posting Setup";
264254
CreateAUBankAccPostingGrp: Codeunit "Create AU Bank Acc Posting Grp";
265255
CreateAUPaymentMethod: Codeunit "Create AU Payment Method";
266256
CreateAUBankAccount: Codeunit "Create AU Bank Account";
@@ -299,7 +289,6 @@ codeunit 17131 "AU Contoso Localization"
299289
end;
300290
Enum::"Contoso Demo Data Module"::Inventory:
301291
begin
302-
UnbindSubscription(CreateAUInvPostingSetup);
303292
UnbindSubscription(CreateAUItem);
304293
UnbindSubscription(CreateAULocation);
305294
end;

0 commit comments

Comments
 (0)