From 5e9c78f6f14a794a98dd1fa319630101f1982e55 Mon Sep 17 00:00:00 2001 From: Patrik Ivarsson Date: Tue, 28 Jan 2025 15:57:40 +0100 Subject: [PATCH] code review: add additional assert Signed-off-by: Patrik Ivarsson --- .../core/instrument/binder/logging/Log4j2MetricsTest.java | 1 + 1 file changed, 1 insertion(+) diff --git a/micrometer-core/src/test/java/io/micrometer/core/instrument/binder/logging/Log4j2MetricsTest.java b/micrometer-core/src/test/java/io/micrometer/core/instrument/binder/logging/Log4j2MetricsTest.java index 824f3bad28..a3e3be881c 100644 --- a/micrometer-core/src/test/java/io/micrometer/core/instrument/binder/logging/Log4j2MetricsTest.java +++ b/micrometer-core/src/test/java/io/micrometer/core/instrument/binder/logging/Log4j2MetricsTest.java @@ -270,6 +270,7 @@ void shouldNotRebindMetricsIfBinderIsClosed() { try (Log4j2Metrics metrics = new Log4j2Metrics(emptyList(), context)) { metrics.bindTo(registry); logger.error("first"); + assertThat(registry.get("log4j2.events").tags("level", "error").counter().count()).isEqualTo(1); } // This will reload the configuration to default