Skip to content

Commit 26fc0f4

Browse files
committed
Updates to Log4j2Metrics from code review
Signed-off-by: Patrik Ivarsson <[email protected]>
1 parent ffe57d9 commit 26fc0f4

File tree

1 file changed

+5
-1
lines changed
  • micrometer-core/src/main/java/io/micrometer/core/instrument/binder/logging

1 file changed

+5
-1
lines changed

micrometer-core/src/main/java/io/micrometer/core/instrument/binder/logging/Log4j2Metrics.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,9 @@ public void bindTo(MeterRegistry registry) {
8989

9090
PropertyChangeListener changeListener = listener -> {
9191
if (listener.getNewValue() instanceof Configuration && listener.getOldValue() != listener.getNewValue()) {
92-
registerMetricsFilter((Configuration) listener.getNewValue(), registry);
92+
Configuration newConfiguration = (Configuration) listener.getNewValue();
93+
registerMetricsFilter(newConfiguration, registry);
94+
loggerContext.updateLoggers(newConfiguration);
9395
if (listener.getOldValue() instanceof Configuration) {
9496
removeMetricsFilter((Configuration) listener.getOldValue());
9597
}
@@ -138,13 +140,15 @@ private MetricsFilter getOrCreateMetricsFilterAndStart(MeterRegistry registry) {
138140
@Override
139141
public void close() {
140142
changeListeners.forEach(loggerContext::removePropertyChangeListener);
143+
changeListeners.clear();
141144

142145
if (!metricsFilters.isEmpty()) {
143146
Configuration configuration = loggerContext.getConfiguration();
144147
removeMetricsFilter(configuration);
145148
loggerContext.updateLoggers(configuration);
146149

147150
metricsFilters.values().forEach(MetricsFilter::stop);
151+
metricsFilters.clear();
148152
}
149153
}
150154

0 commit comments

Comments
 (0)