Skip to content

Commit e08309e

Browse files
committed
It's hard to tell where onClick is targeted, so rename onClick to onOverlayClick.
1 parent dea9292 commit e08309e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/index.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import disableScroll from 'disable-scroll';
55
export interface ModalProps {
66
children: React.ReactNode;
77
isOpen: boolean;
8-
onClick: React.MouseEventHandler<HTMLDivElement>;
8+
onOverlayClick: React.MouseEventHandler<HTMLDivElement>;
99
elementId: 'root' | string;
1010
};
1111

@@ -51,13 +51,13 @@ const containerStyle: React.CSSProperties = {
5151
zIndex: 100001,
5252
};
5353

54-
const Modal: React.FC<ModalProps> = ({ children, isOpen = false, onClick, elementId = 'root' }) => {
54+
const Modal: React.FC<ModalProps> = ({ children, isOpen = false, onOverlayClick, elementId = 'root' }) => {
5555
if (isOpen === false) {
5656
return null;
5757
}
5858
return createPortal(
5959
<div style={wrapperStyle}>
60-
<div style={overlayStyle} onClick={onClick} />
60+
<div style={overlayStyle} onClick={onOverlayClick} />
6161
<div style={containerStyle}>{children}</div>
6262
</div>,
6363
document.getElementById(elementId) as HTMLElement
@@ -89,7 +89,7 @@ export const useModal: UseModal = (elementId = 'root', options = {}) => {
8989
const ModalWrapper = useCallback(
9090
({ children }) => {
9191
return (
92-
<Modal isOpen={isOpen} onClick={onOverlayClick} elementId={elementId}>
92+
<Modal isOpen={isOpen} onOverlayClick={onOverlayClick} elementId={elementId}>
9393
{children}
9494
</Modal>
9595
);

0 commit comments

Comments
 (0)