codal_port/microbit_soundeffect: Raise exception if volume is above 255.

dpgeorge · dpgeorge · commit de3813848f09 · 2022-09-26T16:21:39.000+10:00
Addresses issue #129. Signed-off-by: Damien George <damien@micropython.org>
diff --git a/src/codal_port/microbit_soundeffect.c b/src/codal_port/microbit_soundeffect.c
@@ -123,6 +123,9 @@ const char *microbit_soundeffect_get_sound_expr_data(mp_obj_t self_in) {
 
 STATIC void sound_expr_encode(microbit_soundeffect_obj_t *self, size_t offset, size_t length, unsigned int value) {
     if (offset == SOUND_EXPR_VOLUME_START_OFFSET || offset == SOUND_EXPR_VOLUME_END_OFFSET) {
+        if (value > 255) {
+            mp_raise_ValueError(MP_ERROR_TEXT("maximum value is 255"));
+        }
         value = SOUND_EXPR_ENCODE_VOLUME(value);
     }
     for (size_t i = length; i > 0; --i) {

Original file line number	Diff line number	Diff line change
`@@ -123,6 +123,9 @@ const char *microbit_soundeffect_get_sound_expr_data(mp_obj_t self_in) {`
`123`	`123`
`124`	`124`	`STATIC void sound_expr_encode(microbit_soundeffect_obj_t *self, size_t offset, size_t length, unsigned int value) {`
`125`	`125`	`if (offset == SOUND_EXPR_VOLUME_START_OFFSET \|\| offset == SOUND_EXPR_VOLUME_END_OFFSET) {`
	`126`	`+ if (value > 255) {`
	`127`	`+ mp_raise_ValueError(MP_ERROR_TEXT("maximum value is 255"));`
	`128`	`+ }`
`126`	`129`	`value = SOUND_EXPR_ENCODE_VOLUME(value);`
`127`	`130`	`}`
`128`	`131`	`for (size_t i = length; i > 0; --i) {`