Prevent double-close panic in conn.Close

inWorker calls Conn.Close() following a read error.  The read error may
be caused by an external caller calling Conn.Close() in an active close
of the established connection.  Only one of the callers shall be
permitted to perform the actual closing.

We're already maintaining a synchronized closed state in Conn.closed,
simply short-circuit Conn.Close() when Conn.closed == true.

Author: Vito Caputo

conn.go

@@ -175,6 +175,13 @@ func (conn *Conn) BusObject() *Object {
 // not be called on shared connections.
 func (conn *Conn) Close() error {
 	conn.outLck.Lock()
+	if conn.closed {
+		// inWorker calls Close on read error, the read error may
+		// be caused by another caller calling Close to shutdown the
+		// dbus connection, a double-close scenario we prevent here.
+		conn.outLck.Unlock()
+		return nil
+	}
 	close(conn.out)
 	conn.closed = true
 	conn.outLck.Unlock()