Merge pull request #3 from michaelNgiri/housekeeping

reconcile branch Housekeeping with master

Author: michaelNgiri

README.md

@@ -1,4 +1,8 @@
 # Fetch-API-Client
-A front end client that makes request to a backend API using fetch 
+An ES6 front end API client that makes request to a backend API using fetch 
 
-homepage: http://devpool-client.herokuapp.com
+homepage: http://devpool-client.herokuapp.com
+
+
+
+[![Maintainability](https://api.codeclimate.com/v1/badges/c15ab3b0f6907b1526ce/maintainability)](https://codeclimate.com/github/michaelNgiri/Fetch-API-Client/maintainability)

scripts/app.js

@@ -40,22 +40,16 @@ function fetchRecentQuestionAnswers(id){
 }
 
 
+
+
 function saveAnswer(questionId) {
- questionId = findDom('featured-question-id').value;
-console.log(questionId);
+     questionId = findDom('featured-question-id').value;
  const userId = findDom('featured-question-user-id').value;
- console.log(userId);
  const answer = findDom('answer-body').value;
- console.log(answer);
-
  const answerUrl = baseUrl+'questions/answers';
 const queryBody = 'question_id='+questionId+'&user_id='+userId+'&answer='+answer;
-console.log(queryBody);
-
 //check if valid characters are entered in answer text
  if (typeof answer === "string" && answer.trim().length >= 5) {
-
-
 fetch(answerUrl,
         {
             method: 'post',
@@ -73,21 +67,12 @@ fetch(answerUrl,
             }else{
                indicateError();
             }
-        // Work with JSON data here
-        console.log(data['message']);
     }).catch(err => {
         console.log(err);
         // Do something for an error here
     });
-
-console.log(answerUrl);
-
 }else{
-    console.log('invalid answer text');
-    const answerStatus = findDom('answer-status');
-            answerStatus.innerHTML = 'please type at least 5 characters';
-            answerStatus.style.color='orange';
-            answerStatus.style.visibility='visible';
+    showAnswerSaveError();
 }
 }
 
@@ -114,4 +99,12 @@ function indicateError(){
                const answerStatus = findDom('answer-status'); 
                         answerStatus.innerHTML = 'Failed to save! Login and try again';
                         answerStatus.style.visibility='visible';
+}
+
+function showAnswerSaveError(){
+    console.log('invalid answer text');
+    const answerStatus = findDom('answer-status');
+            answerStatus.innerHTML = 'please type at least 5 characters';
+            answerStatus.style.color='orange';
+            answerStatus.style.visibility='visible';
 }

scripts/auth.js

@@ -1,23 +1,23 @@
 
 function submitLogin(){
-    const x = document.getElementById('password').value.toString().trim();
-    const y = document.getElementById('email').value.toString().trim();
+    const password = document.getElementById('password').value.toString().trim();
+    const email = document.getElementById('email').value.toString().trim();
     //console.log(x);
    // console.log(y);
-    const body =  'email'+'='+y+'&'+'password'+'='+x;
-    const url = baseUrl+"auth/login";
+    const body =  'email'+'='+email+'&'+'password'+'='+password;
+    const loginUrl = baseUrl+"auth/login";
     //console.log(body);
     //const data = {"email":y, password:x};
-    postQuery(url, body)
+    postQuery(loginUrl, body)
 }
 
-function postQuery(url, body) {
+function postQuery(loginUrl, body) {
     if (!('fetch' in window)) {
         console.log('Fetch API not found, try including the polyfill');
         alert('fetch is disabled in your browser');
         return;
     }
-    fetch(url,
+    fetch(loginUrl,
         {
             method: 'post',
             headers: {

scripts/misc.js

@@ -1,5 +1,5 @@
-//const baseUrl = 'http://localhost:3000/api/v1/';
-const baseUrl = 'https://dev-pool.herokuapp.com/api/v1/';
+const baseUrl = 'http://localhost:3000/api/v1/';
+//const baseUrl = 'https://dev-pool.herokuapp.com/api/v1/';
 
 const authText =  findDom('auth-text');
 let Authorization,