Skip to content

Commit 664217e

Browse files
committed
use ResponseEvent instead of FilterResponseEvent
See symfony/symfony#28920
1 parent be4d433 commit 664217e

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

src/EventListener/JsErrorToAlertListener.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
88
use Symfony\Component\HttpFoundation\Request;
99
use Symfony\Component\HttpFoundation\Response;
10-
use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
10+
use Symfony\Component\HttpKernel\Event\ResponseEvent;
1111
use Symfony\Component\HttpKernel\KernelEvents;
1212

1313
class JsErrorToAlertListener implements EventSubscriberInterface
1414
{
1515

16-
public function onKernelResponse(FilterResponseEvent $event): void
16+
public function onKernelResponse(ResponseEvent $event): void
1717
{
1818
$response = $event->getResponse();
1919
$request = $event->getRequest();

tests/EventListener/JsErrorToAlertListenerTest.php

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
use Symfony\Component\HttpFoundation\Request;
1111
use Symfony\Component\HttpFoundation\Response;
1212
use Symfony\Component\HttpFoundation\StreamedResponse;
13-
use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
13+
use Symfony\Component\HttpKernel\Event\ResponseEvent;
1414
use Symfony\Component\HttpKernel\HttpKernelInterface;
1515
use Symfony\Component\HttpKernel\Kernel;
1616
use Symfony\Component\HttpKernel\KernelEvents;
@@ -52,7 +52,7 @@ public function testScriptIsInjected(string $responseBody, string $expectedRespo
5252
{
5353
$response = new Response($responseBody);
5454

55-
$event = new FilterResponseEvent(
55+
$event = new ResponseEvent(
5656
$this->getKernelMock(),
5757
$this->getRequestMock(),
5858
HttpKernelInterface::MASTER_REQUEST,
@@ -108,7 +108,7 @@ public function testScriptIsNotInjectedOnRedirection(int $statusCode): void
108108
{
109109
$response = new Response(self::BASIC_HTML, $statusCode);
110110

111-
$event = new FilterResponseEvent(
111+
$event = new ResponseEvent(
112112
$this->getKernelMock(),
113113
$this->getRequestMock(),
114114
HttpKernelInterface::MASTER_REQUEST,
@@ -139,7 +139,7 @@ public function testScriptIsNotInjectedToStreamedResponse(): void
139139
{
140140
$response = new StreamedResponse();
141141

142-
$event = new FilterResponseEvent(
142+
$event = new ResponseEvent(
143143
$this->getKernelMock(),
144144
$this->getRequestMock(),
145145
HttpKernelInterface::MASTER_REQUEST,
@@ -156,7 +156,7 @@ public function testScriptIsNotInjectedOnSubRequest(): void
156156
{
157157
$response = new Response(self::BASIC_HTML);
158158

159-
$event = new FilterResponseEvent(
159+
$event = new ResponseEvent(
160160
$this->getKernelMock(),
161161
$this->getRequestMock(),
162162
HttpKernelInterface::SUB_REQUEST,
@@ -176,7 +176,7 @@ public function testScriptIsNotInjectedOnIncompleteHtmlResponses(): void
176176
{
177177
$response = new Response('<div>Some content</div>');
178178

179-
$event = new FilterResponseEvent(
179+
$event = new ResponseEvent(
180180
$this->getKernelMock(),
181181
$this->getRequestMock(),
182182
HttpKernelInterface::MASTER_REQUEST,
@@ -196,7 +196,7 @@ public function testScriptIsNotInjectedOnXmlHttpRequests(): void
196196
{
197197
$response = new Response(self::BASIC_HTML);
198198

199-
$event = new FilterResponseEvent(
199+
$event = new ResponseEvent(
200200
$this->getKernelMock(),
201201
$this->getRequestMock(true),
202202
HttpKernelInterface::MASTER_REQUEST,
@@ -216,7 +216,7 @@ public function testScriptIsNotInjectedOnNonHtmlRequests(): void
216216
{
217217
$response = new Response(self::BASIC_HTML);
218218

219-
$event = new FilterResponseEvent(
219+
$event = new ResponseEvent(
220220
$this->getKernelMock(),
221221
$this->getRequestMock(false, 'json'),
222222
HttpKernelInterface::MASTER_REQUEST,
@@ -237,7 +237,7 @@ public function testScriptIsNotInjectedOnContentDispositionAttachment(): void
237237
$response = new Response(self::BASIC_HTML);
238238
$response->headers->set('Content-Disposition', 'attachment; filename=test.html');
239239

240-
$event = new FilterResponseEvent(
240+
$event = new ResponseEvent(
241241
$this->getKernelMock(),
242242
$this->getRequestMock(),
243243
HttpKernelInterface::MASTER_REQUEST,
@@ -258,7 +258,7 @@ public function testScriptIsNotInjectedOnNonHtmlContentType(): void
258258
$response = new Response(self::BASIC_HTML);
259259
$response->headers->set('Content-Type', 'text/xml');
260260

261-
$event = new FilterResponseEvent(
261+
$event = new ResponseEvent(
262262
$this->getKernelMock(),
263263
$this->getRequestMock(),
264264
HttpKernelInterface::MASTER_REQUEST,

0 commit comments

Comments
 (0)