update dev dependencies

Author: mhujer

.travis.yml

@@ -14,5 +14,5 @@ install:
 script:
   - composer run build
 
-after_script:
-  - php vendor/bin/coveralls -v
+after_success:
+  - travis_retry php vendor/bin/php-coveralls -v

composer.json

@@ -26,13 +26,14 @@
 		"symfony/http-kernel": "^3.3|^4.0"
 	},
 	"require-dev": {
-		"consistence/coding-standard": "2.2.1",
-		"jakub-onderka/php-parallel-lint": "0.9.2",
-		"matthiasnoback/symfony-config-test": "3.0.1",
-		"matthiasnoback/symfony-dependency-injection-test": "2.2.0",
-		"phpstan/phpstan-shim": "0.8.4",
-		"phpunit/phpunit": "6.4.3",
-		"satooshi/php-coveralls": "1.0.1"
+		"consistence/coding-standard": "3.5",
+		"jakub-onderka/php-parallel-lint": "1.0.0",
+		"matthiasnoback/symfony-config-test": "4.0.0",
+		"matthiasnoback/symfony-dependency-injection-test": "3.0.0",
+		"phpstan/phpstan-shim": "0.10.5",
+		"phpstan/phpstan-phpunit": "0.10",
+		"phpunit/phpunit": "7.4.4",
+		"php-coveralls/php-coveralls": "2.1.0"
 	},
 	"autoload": {
 		"psr-4": {
@@ -64,7 +65,8 @@
 		],
 		"phplint": "parallel-lint src tests",
 		"phpcs": "phpcs --standard=ruleset.xml src tests",
-		"phpstan": "php vendor/phpstan/phpstan-shim/phpstan.phar analyse src tests --level 7 --no-progress",
+		"phpcbf": "phpcbf --standard=ruleset.xml src tests",
+		"phpstan": "php vendor/phpstan/phpstan-shim/phpstan.phar analyse -c phpstan.neon src tests --level 7 --no-progress",
 		"phpunit": "phpunit"
 	}
 }

phpstan.neon

@@ -0,0 +1,6 @@
+includes:
+    - vendor/phpstan/phpstan-phpunit/extension.neon
+
+parameters:
+    ignoreErrors:
+        - '#Call to an undefined method Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition\:\:children\(\)\.#'

src/EventListener/JsErrorToAlertListener.php

@@ -30,16 +30,24 @@ public function onKernelResponse(FilterResponseEvent $event): void
 			return;
 		}
 
-		if ($response->headers->has('Content-Type') && strpos($response->headers->get('Content-Type'), 'html') === false) {
-			return;
+		if ($response->headers->has('Content-Type')) {
+			/** @var string $contentTypeHeader */
+			$contentTypeHeader = $response->headers->get('Content-Type');
+			if (strpos($contentTypeHeader, 'html') === false) {
+				return;
+			}
 		}
 
 		if ($request->getRequestFormat() !== 'html') {
 			return;
 		}
 
-		if ($response->headers->has('Content-Disposition') && stripos($response->headers->get('Content-Disposition'), 'attachment;') !== false) {
-			return;
+		if ($response->headers->has('Content-Disposition')) {
+			/** @var string $contentDispositionHeader */
+			$contentDispositionHeader = $response->headers->get('Content-Disposition');
+			if (stripos($contentDispositionHeader, 'attachment;') !== false) {
+				return;
+			}
 		}
 
 		$this->injectScript($response, $request);

tests/DependencyInjection/JavaScriptErrorHandlerExtensionTest.php

@@ -12,7 +12,10 @@ class JavaScriptErrorHandlerExtensionTest extends AbstractExtensionTestCase
 
 	private const LISTENER_CLASS_NAME = JsErrorToAlertListener::class;
 
-	protected function getContainerExtensions()
+	/**
+	 * @return \Symfony\Component\DependencyInjection\Extension\Extension[]
+	 */
+	protected function getContainerExtensions(): array
 	{
 		return [
 			new JavaScriptErrorHandlerExtension(),

tests/EventListener/JsErrorToAlertListenerTest.php

@@ -29,7 +29,7 @@ public function testIsSubscribedToKernelResponse(): void
 	 * @param string $responseBody
 	 * @param string $expectedResponse
 	 */
-	public function testInjectScript(string $responseBody, string $expectedResponse)
+	public function testInjectScript(string $responseBody, string $expectedResponse): void
 	{
 		$listener = new JsErrorToAlertListener();
 		$injectScriptReflection = new ReflectionMethod($listener, 'injectScript');
@@ -47,7 +47,7 @@ public function testInjectScript(string $responseBody, string $expectedResponse)
 	 * @param string $responseBody
 	 * @param string $expectedResponse
 	 */
-	public function testScriptIsInjected(string $responseBody, string $expectedResponse)
+	public function testScriptIsInjected(string $responseBody, string $expectedResponse): void
 	{
 		$response = new Response($responseBody);
 
@@ -103,7 +103,7 @@ public function htmlScriptDataProvider(): array
 	 * @dataProvider redirectCodesDataProvider
 	 * @param int $statusCode
 	 */
-	public function testScriptIsNotInjectedOnRedirection(int $statusCode)
+	public function testScriptIsNotInjectedOnRedirection(int $statusCode): void
 	{
 		$response = new Response(self::BASIC_HTML, $statusCode);
 
@@ -123,7 +123,10 @@ public function testScriptIsNotInjectedOnRedirection(int $statusCode)
 		);
 	}
 
-	public function redirectCodesDataProvider()
+	/**
+	 * @return int[][]
+	 */
+	public function redirectCodesDataProvider(): array
 	{
 		return [
 			[301],
@@ -253,6 +256,9 @@ public function testScriptIsNotInjectedOnNonHtmlContentType(): void
 		);
 	}
 
+	/**
+	 * @return \PHPUnit_Framework_MockObject_MockObject|\Symfony\Component\HttpKernel\Kernel
+	 */
 	protected function getKernelMock()
 	{
 		/** @var \Symfony\Component\HttpKernel\Kernel|\PHPUnit_Framework_MockObject_MockObject $kernelMock */
@@ -263,7 +269,12 @@ protected function getKernelMock()
 		return $kernelMock;
 	}
 
-	protected function getRequestMock($isXmlHttpRequest = false, $requestFormat = 'html')
+	/**
+	 * @param bool $isXmlHttpRequest
+	 * @param string $requestFormat
+	 * @return \PHPUnit_Framework_MockObject_MockObject|\Symfony\Component\HttpFoundation\Request
+	 */
+	protected function getRequestMock(bool $isXmlHttpRequest = false, string $requestFormat = 'html')
 	{
 		/** @var \Symfony\Component\HttpFoundation\Request|\PHPUnit_Framework_MockObject_MockObject $request */
 		$request = $this